Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pytest-instafail: init at 0.4.2 #110138

Merged
merged 3 commits into from Jan 20, 2021
Merged

pythonPackages.pytest-instafail: init at 0.4.2 #110138

merged 3 commits into from Jan 20, 2021

Conversation

jacg
Copy link
Contributor

@jacg jacg commented Jan 20, 2021

Motivation for this change

Package not yet available in nixpkgs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member

fabaff commented Jan 20, 2021

Result of nixpkgs-review pr 110138 run on x86_64-linux 1

3 packages built:
  • python37Packages.pytest-instafail
  • python38Packages.pytest-instafail
  • python39Packages.pytest-instafail

@jacg jacg changed the title pytest-instafail: init at 0.4.2 pythonPackages.pytest-instafail: init at 0.4.2 Jan 20, 2021
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 20, 2021 •
edited

Please do not rebase PRs on master when not fixing merge conflicts or there is no good reason for it.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110138 run on x86_64-linux 1

3 packages built:
  • python37Packages.pytest-instafail
  • python38Packages.pytest-instafail
  • python39Packages.pytest-instafail

jacg and others added 2 commits January 20, 2021 13:34
@jacg @fabaff
Change license from 'free' to 'bsd3'
0816125 
Co-authored-by: Fabian Affolter <mail@fabian-affolter.ch>
@jacg @fabaff
Add pythonImportsCheck
2e36c01 
Co-authored-by: Fabian Affolter <mail@fabian-affolter.ch>
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110138 run on x86_64-darwin 1

3 packages built:
  • python37Packages.pytest-instafail
  • python38Packages.pytest-instafail
  • python39Packages.pytest-instafail

@SuperSandro2000 SuperSandro2000 merged commit f421371 into NixOS:master Jan 20, 2021
@jacg jacg deleted the pytest-instafail branch January 20, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacg @fabaff @SuperSandro2000