Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mailspring: 1.7.8 -> 1.8.0 #110135

Merged
merged 1 commit into from Jan 20, 2021
Merged

mailspring: 1.7.8 -> 1.8.0 #110135

merged 1 commit into from Jan 20, 2021

Conversation

doronbehar
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from toschmidt January 20, 2021 11:06
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110135 run on x86_64-linux 1

1 package built:
  • mailspring

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

mailspring:

Please consider this feature to be alpha.

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern 'realpath' doesn't match anything in file '/nix/store/jw6ahx1hkp9mvc8in25y371bqjbbss0m-mailspring-1.8.0/share/mailspring/resources/app.asar.unpacked/mailsync'

Please check the offending substituteInPlace for typos or changes in source.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110135 run on x86_64-linux 1

1 package built:
  • mailspring

@SuperSandro2000 SuperSandro2000 merged commit 1cd0cd0 into NixOS:master Jan 20, 2021
@doronbehar doronbehar deleted the pkg/mailspring branch April 15, 2021 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toschmidt toschmidt toschmidt approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doronbehar @SuperSandro2000 @toschmidt