darwin.apple-sdk: drop appleSdkVersion #110140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: darwin
SuperSandro2000
approved these changes
Jan 20, 2021
|
That one can go straight to master because it is zero rebuilds. |
holymonson
requested review from
FRidh,
jonringer,
kalbasit,
Mic92 and
zowoq
as code owners
In fact no one is using appleSdkVersion, and stdenv is decoupled with sdk.
holymonson
force-pushed
the
prepare-apple-sdk
branch
from
0331c80
to
2467f5e
Compare
|
cc @NixOS/darwin-maintainers |
|
Looks good! |
matthewbauer
approved these changes
Jan 20, 2021
21 tasks
thefloweringash
added a commit
to thefloweringash/nixpkgs
that referenced
this pull request
Jan 28, 2021
Also use matching attribute for `-macosx_version_min`. See NixOS#110140
andir
pushed a commit
to andir/nixpkgs
that referenced
this pull request
Jan 30, 2021
Also use matching attribute for `-macosx_version_min`. See NixOS#110140
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
In fact no one is using appleSdkVersion, and stdenv should be decoupled with sdk.
This PR is picked alone because I'm decoupling apple_sdk and this one will cause mass rebuild, while the later ones won't.
cc @veprbl @SuperSandro2000
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)