Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnomeExtensions.fuzzy-app-search: init at 4 #110017

Merged
merged 1 commit into from Feb 13, 2021
Merged

gnomeExtensions.fuzzy-app-search: init at 4 #110017

merged 1 commit into from Feb 13, 2021

Conversation

rhoriguchi
Copy link
Contributor

@rhoriguchi rhoriguchi commented Jan 19, 2021

Motivation for this change

Add support for GNOME extension Fuzzy App Search

The patch is necessary because Nix doesn't use /usr/share/applications and ~/.local/share/applications. I've opened a PR to apply this patch to the extension.

Example in README works:

image

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rhoriguchi rhoriguchi changed the title gnomeExtensions.fuzzy-app-search: init at 4 WIP gnomeExtensions.fuzzy-app-search: init at 4 Jan 19, 2021
@rhoriguchi
Copy link
Contributor Author

This is a fork of https://github.com/fffilo/gnome-fuzzy-search but this repo had it's last commit in May 2020. On the GNOME extension page it is listed under the GitHub repo. Should I rename the package or is this fine?

@rhoriguchi rhoriguchi changed the title WIP gnomeExtensions.fuzzy-app-search: init at 4 gnomeExtensions.fuzzy-app-search: init at 4 Jan 19, 2021
src = fetchFromGitLab {
owner = "Czarlie";
repo = "gnome-fuzzy-app-search";
rev = "da9c15d39958d9c3b38df3b616fd40b85aed24e5";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this issue is not being resolved, could this be merged?

The commit I've chosen is the one that last touched the metadata.json.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks for the contribution.

@jtojnar jtojnar merged commit ff96a0f into NixOS:master Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants