Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libosmpbf: 1.3.3 -> 1.5.0 #110067

Merged
merged 1 commit into from Feb 26, 2021
Merged

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libosmpbf/versions.

meta.description for libosmpbf is: "C library to read and write OpenStreetMap PBF files"

meta.homepage for libosmpbf is: "https://github.com/scrosby/OSM-binary"

meta.changelog for libosmpbf is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
libosmpbf
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/0kn6ixcn5ggywv9m6qvybiqky20mz669-libosmpbf-1.5.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A libosmpbf https://github.com/r-ryantm/nixpkgs/archive/bbac2ae6d05190734be83f0d10d9d4bcf310e14c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/0kn6ixcn5ggywv9m6qvybiqky20mz669-libosmpbf-1.5.0
ls -la /nix/store/0kn6ixcn5ggywv9m6qvybiqky20mz669-libosmpbf-1.5.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • libosmpbf

Maintainer pings

@bobrik
Copy link
Contributor

bobrik commented Mar 3, 2021

The upgrade broke x86_64-darwin: https://hydra.nixos.org/job/nixpkgs/staging-next/libosmpbf.x86_64-darwin

The upstream switched to cmake for builds, but given that the package was introduced as a dependency of osrm-backend, which no longer depends on libosmpbf, it may be easier to remove than to fix.

@tomberek
Copy link
Contributor

tomberek commented Mar 3, 2021

Result of nixpkgs-review pr 110067 run on x86_64-darwin 1

1 package failed to build:
  • libosmpbf

@tomberek
Copy link
Contributor

tomberek commented Mar 3, 2021

note for future efforts:

  • went partly down the path of trying to use cmake
  • ran into issues with protobuf-module.cmake and some other cmake include's being needed.
  • Seems like bloaty and onnxruntime.dev have these modules. in /lib/cmake/protobuf

@bobrik
Copy link
Contributor

bobrik commented Mar 3, 2021

The idea is to run cmake from repo root and install the whole thing (including the binary), not from src.

That way it works just fine.

@tomberek
Copy link
Contributor

tomberek commented Mar 3, 2021

osrm-backend is already using cmake. So just remove this?

@bobrik
Copy link
Contributor

bobrik commented Mar 3, 2021

Yeah, I think if it's needed people will complain and it can be resurrected.

@tomberek tomberek mentioned this pull request Mar 3, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants