Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mitmproxy: 5.3.0 -> 6.0.2 #110091

Closed
wants to merge 2 commits into from
Closed

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/mitmproxy/versions.

meta.description for mitmproxy is: "Man-in-the-middle proxy"

meta.homepage for mitmproxy is: "https://mitmproxy.org/"

meta.changelog for mitmproxy is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
16 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
4 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
mitmproxy
python37Packages.mitmproxy
python38Packages.mitmproxy
python39Packages.mitmproxy
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/184y4cvysswzf66nmjrjdn6d621c66bd-python3.8-mitmproxy-6.0.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A mitmproxy https://github.com/r-ryantm/nixpkgs/archive/6abcea78181e620b7ff91f83e83e1e227f4a17f4.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/184y4cvysswzf66nmjrjdn6d621c66bd-python3.8-mitmproxy-6.0.2
ls -la /nix/store/184y4cvysswzf66nmjrjdn6d621c66bd-python3.8-mitmproxy-6.0.2/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:
  • python37Packages.mitmproxy
2 packages built:
  • mitmproxy (python38Packages.mitmproxy)
  • python39Packages.mitmproxy

Maintainer pings

cc @fpletz @kamilchm for testing.

@fabaff
Copy link
Member

fabaff commented Jan 21, 2021

Result of nixpkgs-review pr 110091 run on x86_64-linux 1

1 package failed to build:
  • python37Packages.mitmproxy
2 packages built:
  • mitmproxy (python38Packages.mitmproxy)
  • python39Packages.mitmproxy

@SuperSandro2000
Copy link
Member

If this update requires more changes you could open a new PR so that you can easily apply those.

@divanorama
Copy link
Contributor

python37Packages.mitmproxy failure is due to dropped support for python <=3.7
https://mitmproxy.org/posts/releases/mitmproxy6/

@divanorama
Copy link
Contributor

compiles, starts, seems to work on Gentoo amd64 sandbox=true

@fabaff
Copy link
Member

fabaff commented Jan 23, 2021

At first glance there are some install requirements are missing at least publicsuffix2 and h11. I have not check if those are indirect deps but I still think that we should add them to avoid installation issues in case the used module is dropping them.

@dotlambda
Copy link
Member

@fabaff Would you mind opening your own PR?

@fabaff fabaff mentioned this pull request Feb 21, 2021
10 tasks
@fabaff
Copy link
Member

fabaff commented Feb 21, 2021

Closed in favor of #113948.

@fabaff fabaff closed this Feb 21, 2021
@r-ryantm r-ryantm deleted the auto-update/mitmproxy branch February 22, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants