Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gperftools: 2.8 -> 2.8.1 #110025

Merged
merged 1 commit into from Jan 20, 2021
Merged

gperftools: 2.8 -> 2.8.1 #110025

merged 1 commit into from Jan 20, 2021

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jan 19, 2021 •
edited

Motivation for this change
  • version update
  • replace fetchurl with fetchFromGitHub
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak requested a review from vcunat January 19, 2021 22:05
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110025 run on x86_64-linux 1

5 packages marked as broken and skipped:
  • gnutls-kdh
  • hhvm
  • lean2
  • maxscale
  • tlspool
16 packages built:
  • gperftools
  • hpx
  • katago
  • katagoCPU
  • katagoWithCuda
  • mongodb (mongodb-3_4)
  • mongodb-3_6
  • mongodb-4_0
  • mongodb-4_2
  • python37Packages.sentencepiece
  • python38Packages.sentencepiece
  • python39Packages.sentencepiece
  • sentencepiece
  • tengine
  • wiredtiger
  • zeek

vcunat
vcunat approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried really using it so far, but it looks good and unlikely to break stuff .

@prusnak prusnak merged commit cfdd677 into NixOS:master Jan 20, 2021
@prusnak prusnak deleted the gperftools branch January 20, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @SuperSandro2000 @vcunat