Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: editorconfig fixes #110028

Merged
merged 1 commit into from Jan 19, 2021
Merged

treewide: editorconfig fixes #110028

merged 1 commit into from Jan 19, 2021

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jan 19, 2021

Should be zero rebuilds.

@zowoq
treewide: editorconfig fixes
6aa7cf1 
- remove trailing whitespace
- use spaces for indentation
@zowoq zowoq mentioned this pull request Jan 19, 2021
Closed
10 tasks
jonringer
jonringer approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did a really quick scan, LGTM

assuming no rebuilds

SuperSandro2000
SuperSandro2000 approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also did a quick scroll through and did not see anything.

@zowoq zowoq marked this pull request as ready for review January 19, 2021 22:52
@zowoq
Copy link
Contributor Author

zowoq commented Jan 19, 2021

Before: 877 errors in 253 files
After: 751 errors in 112 files

@zowoq zowoq merged commit 31f5dd3 into NixOS:master Jan 19, 2021
@zowoq zowoq deleted the ecc branch January 19, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@jonringer jonringer jonringer approved these changes

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

Assignees
No one assigned
Labels
6.topic: fetch 6.topic: haskell 6.topic: python 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @SuperSandro2000 @jonringer