Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-fonts: 2019-07-14 -> unstable-2021-01-19 #110027

Merged
merged 1 commit into from Jan 27, 2021
Merged

google-fonts: 2019-07-14 -> unstable-2021-01-19 #110027

merged 1 commit into from Jan 27, 2021

Conversation

tu-maurice
Copy link
Contributor

@tu-maurice tu-maurice commented Jan 19, 2021 •
edited by SuperSandro2000

Motivation for this change

Closes #109245

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110027 run on x86_64-darwin 1

1 package built:
  • inconsolata

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 20, 2021 •
edited

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110027 run on x86_64-linux 1

1 package failed to build and are new build failure:
  • ricty: log was empty
1 package built:
  • inconsolata
builder for '/nix/store/1fniq0b82853s80210c5pi8d88khbaka-ricty_generator-4.1.1.sh.drv' failed with exit code 1; last 7 log lines:                                                                                                                                                                                                                                                         trying http://www.yusa.lab.uec.ac.jp/~yusa/ricty/ricty_generator-4.1.1.sh
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
	                                   Dload  Upload   Total   Spent    Left  Speed
									       0     0    0     0    0     0      0      0 --:--:--  0:00:02 --:--:--     0
										     curl: (22) The requested URL returned error: 404 Not Found
											   error: cannot download ricty_generator-4.1.1.sh from any mirror
											   cannot build derivation '/nix/store/q5xr9i09bmaxs4445v1c74vrim8bi8a4-ricty-4.1.1.drv': 1 dependencies couldn't be built
											   cannot build derivation '/nix/store/5x20nra7hlyidbz070i9wbj1vaf7lmy1-env.drv': 1 dependencies couldn't be built

Unrelated.

@tu-maurice
Copy link
Contributor Author

@SuperSandro2000 Just want to ask if there is any reason left not to merge this?

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110027 run on x86_64-darwin 1

1 package built:
  • inconsolata

@SuperSandro2000 SuperSandro2000 merged commit bd90b97 into NixOS:master Jan 27, 2021
@ghost
Copy link

ghost commented Feb 1, 2021 •
edited by ghost

This breaks the inconsolata package:

[pbb@regolith:~/proj/nixpkgs]$ l old/share/fonts/truetype/inconsolata/
Permissions Size User Date Modified Name
.r--r--r--  108k root  1 Jan  1970  Inconsolata-Bold.ttf
.r--r--r--   95k root  1 Jan  1970  Inconsolata-Regular.ttf

[pbb@regolith:~/proj/nixpkgs]$ l new/share/fonts/truetype/inconsolata/
Permissions Size User Date Modified Name
.r--r--r--  347k root  1 Jan  1970  Inconsolata[wdth,wght].ttf

[pbb@regolith:~/proj/nixpkgs]$

@ghost ghost mentioned this pull request Feb 1, 2021
Merged
10 tasks
ghost pushed a commit that referenced this pull request Feb 1, 2021
inconsolata: change source path for new google fonts (#111556)
26187c6 
#110027 updated google-fonts to a new version. In the source of the new
version, the built Inconsolata font files are in a different
subdirectory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update google-fonts 2019-07-14 -> 2021-01-??
2 participants
@tu-maurice @SuperSandro2000