halide: Enable on platforms.all #110106
halide: Enable on platforms.all #110106
Conversation
ofborg
bot
added
6.topic: darwin
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 0
labels
| @@ -49,7 +49,7 @@ llvmPackages.stdenv.mkDerivation rec { | |||
| description = "C++ based language for image processing and computational photography"; | |||
| homepage = "https://halide-lang.org"; | |||
| license = licenses.mit; | |||
| platforms = [ "i686-linux" "x86_64-linux" "aarch64-linux" ]; | |||
| platforms = [ "i686-linux" "x86_64-linux" "aarch64-linux" "x86_64-darwin" ]; | |||
There was a problem hiding this comment.
We could probably just set platforms to all, right?
|
I think 10.0 is old enough it wouldn’t support m1 macs, and iOS probably
isn’t supported as a host architecture.
On Wed, Jan 20, 2021 at 01:08 Sandro ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkgs/development/compilers/halide/default.nix
<#110106 (comment)>:
> @@ -49,7 +49,7 @@ llvmPackages.stdenv.mkDerivation rec {
description = "C++ based language for image processing and computational photography";
homepage = "https://halide-lang.org";
license = licenses.mit;
- platforms = [ "i686-linux" "x86_64-linux" "aarch64-linux" ];
+ platforms = [ "i686-linux" "x86_64-linux" "aarch64-linux" "x86_64-darwin" ];
We could probably just set platforms to all, right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#110106 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVRX5HHIQGTHW434FT7JADS22MP3ANCNFSM4WKJ4A2A>
.
--
- Steven
|
I am pretty sure that most packages in nixpkgs do not account for those arches at all. Also please change the PR title and commit message to |
spease
changed the title
spease
force-pushed
the
enable-halide-x86_64-darwin
branch
from
5de5848
to
41d9dec
Compare
|
I've changed the PR title and commit message. Do you also want me to change to platforms.all? I have only positively tested on x86_64-darwin |
It will most likely also work on all the other platforms and if not this is mostly for hydra anyway. |
SuperSandro2000
changed the title
|
This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package built:
|
Motivation for this change
Enable x86_64-darwin support on Halide
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Seems pretty straightforward. I think the only reason it wasn't enabled was because nobody thought to when the package was upgraded from 8.0 to 10.0.