Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cifs-utils: missing python3 dependency for smbinfo #110107

Merged
merged 1 commit into from Jan 20, 2021
Merged

cifs-utils: missing python3 dependency for smbinfo #110107

merged 1 commit into from Jan 20, 2021

Conversation

LeSuisse
Copy link
Contributor

Motivation for this change

Since cifs-utils 6.12, smbinfo needs Python to be usable.

Issue introduced in 033208f.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Can you add a check to catch such regressions in the future?

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110107 run on x86_64-linux 1

5 packages built:
  • autofs5
  • cifs-utils
  • rmount
  • roon-server
  • sssd

@LeSuisse
cifs-utils: missing python3 dependency for smbinfo
5858d84 
Since cifs-utils 6.12, smbinfo needs Python to be usable.

Issue introduced in 033208f.
@LeSuisse LeSuisse force-pushed the cifs-utils-missing-python3-smbinfo branch from d6f1cc0 to 5858d84 Compare January 20, 2021 17:40
@LeSuisse
Copy link
Contributor Author

Can you add a check to catch such regressions in the future?

I have added some basic tests to at least avoid this sort of issues in the future.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110107 run on x86_64-linux 1

5 packages built:
  • autofs5
  • cifs-utils
  • rmount
  • roon-server
  • sssd

@SuperSandro2000 SuperSandro2000 merged commit ec84cbf into NixOS:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LeSuisse @SuperSandro2000