Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bind: Add types for options #110131

Merged
merged 1 commit into from Jan 31, 2021
Merged

bind: Add types for options #110131

merged 1 commit into from Jan 31, 2021

Conversation

Scriptkiddi
Copy link
Contributor

Motivation for this change

fixes in the list of #76184

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Lassulus Lassulus merged commit 4c181d1 into NixOS:master Jan 31, 2021
@ghost
Copy link

ghost commented Jan 31, 2021

This broke my eval. I will look into it.

@ghost
Copy link

ghost commented Jan 31, 2021 •
edited by ghost

So I generate my zone files using nix-dns and it outputs a derivation (types.package) for the zone file.

error: A definition for option `services.bind.zones.[definition 1-entry 1].file' is not of type `string'. Definition values:
- In `/home/pbb/proj/nixfiles/modules/dns': <derivation /nix/store/mrrq2amn0sgwkapk661ak5gk71jvgjcf-0.c.a.4.f.0.a.2.ip6.arpa.zone.drv>
(use '--show-trace' to show detailed location information)

Should we change the .file option to with types; oneOf [ str package path ] or do you think this should not be a supported use case or I would have to put the value in "${}" in my config?

@Scriptkiddi Scriptkiddi mentioned this pull request Jan 31, 2021
Merged
10 tasks
@Scriptkiddi
Copy link
Contributor Author

i think you should put "${}" in your config but i added the path option to allow rollbacks for zone files https://github.com/NixOS/nixpkgs/pull/111470/files

@dasJ dasJ deleted the bind_types branch October 15, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus left review comments

@aanderse aanderse aanderse left review comments

@peti peti Awaiting requested review from peti peti is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Scriptkiddi @Lassulus @aanderse