Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.crccheck: 0.6 -> 1.0 #109961

Merged
merged 1 commit into from Jan 20, 2021
Merged

python3Packages.crccheck: 0.6 -> 1.0 #109961

merged 1 commit into from Jan 20, 2021

Conversation

etu
Copy link
Contributor

@etu etu commented Jan 19, 2021

Motivation for this change

Follow up on #99446 with less of the confusion and mess.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu
Copy link
Contributor Author

etu commented Jan 19, 2021

@ofborg eval

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109961 run on x86_64-linux 1

24 packages built:
  • python37Packages.bellows
  • python37Packages.crccheck
  • python37Packages.zha-quirks
  • python37Packages.zigpy
  • python37Packages.zigpy-deconz
  • python37Packages.zigpy-znp
  • python38Packages.bellows
  • python38Packages.crccheck
  • python38Packages.zha-quirks
  • python38Packages.zigpy
  • python38Packages.zigpy-cc
  • python38Packages.zigpy-deconz
  • python38Packages.zigpy-xbee
  • python38Packages.zigpy-zigate
  • python38Packages.zigpy-znp
  • python39Packages.bellows
  • python39Packages.crccheck
  • python39Packages.zha-quirks
  • python39Packages.zigpy
  • python39Packages.zigpy-cc
  • python39Packages.zigpy-deconz
  • python39Packages.zigpy-xbee
  • python39Packages.zigpy-zigate
  • python39Packages.zigpy-znp

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.bellows:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
python38Packages.bellows:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
python39Packages.bellows:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

@SuperSandro2000 SuperSandro2000 merged commit a121a5c into NixOS:master Jan 20, 2021
@etu etu deleted the python-crccheck-update-2 branch January 20, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etu @SuperSandro2000