Fix two problems with terraform limits #8782
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8611
Motivation / Problem
I am not pointing fingers, but someone broke terraform limits when maxing out values :D
Additionally, when maxing out other values, you could constantly overflow the terraform limit, getting into a weird state of being allowed to terraform or not, depending on your game-tick.
Description
signed vs unsigned
uint32 + uint32 != uint64
C++ is making this very difficult for us :'(
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.