Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing spaces that hang don't contribute to intrinsic size #27836

Merged
merged 1 commit into from May 6, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 1, 2021

During the min-content contribution we should use the non-hangable run
end, unless the white-space property is set to 'break-spaces'.

Additionally, we should ensure that hanging trailing spaces doesn't
account for the NGItemResult's inline size.

Bug: 972992, 1071928
Change-Id: Ife1b3212164b1494e822fa141cd44896e6359ef9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418678
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#879781}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [WIP] Trailing spaces that hang don't contribute to intrinsic size Trailing spaces that hang don't contribute to intrinsic size Mar 3, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2418678 branch 2 times, most recently from bf2ff96 to 591ac8a Compare April 27, 2021 12:52
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2418678 branch 2 times, most recently from 0d884d9 to 6043b4d Compare May 4, 2021 10:30
During the min-content contribution we should use the non-hangable run
end, unless the white-space property is set to 'break-spaces'.

Additionally, we should ensure that hanging trailing spaces doesn't
account for the NGItemResult's inline size.

Bug: 972992, 1071928
Change-Id: Ife1b3212164b1494e822fa141cd44896e6359ef9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418678
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#879781}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants