Window Placement: Implement Screens and ScreenAdvanced interfaces #27581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 10, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2669359
branch
6 times, most recently
from
4021ce1
to
ea82905
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2669359
branch
17 times, most recently
from
81c1b0e
to
8e4cc2a
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2669359
branch
3 times, most recently
from
5a992d1
to
1db47fc
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2669359
branch
5 times, most recently
from
49f83fa
to
5f2b0c0
Compare
This CL makes the following changes for a planned API redesign: docs.google.com/document/d/1lgCentReLlym6j9kBS_Qo3r2HHZ6Ov7cSGjSWyi8cYs 1) Add Screens interface to vend multi-screen info for windowing. - RuntimeEnabled and permission-gated; designed like window.screen. 2) Add ScreenAdvanced interface, to extend Screen with extra info. - Make Screen impl non-final; override functions in ScreenAdvanced. 3) Add WindowScreens supplement, to host Window.getScreens(). - Rename the previous API access point to getScreensDeprecated(). 4) Add ScreenInfo::is_primary & is_internal to expose in ScreenAdvanced. - Add ScreenInfo::display_id for internal logic, it is not web-exposed. 5) Propagate multi-screen VisualProperties from browser to renderers: - Replace the singular ScreenInfo member with a new ScreenInfos struct. - Encapsulates multi-screen information and a current screen id. - Add [mutable_]current() for easy/legacy access to the current screen. - Validate mojo struct traits in [de]serialization; add tests. 6) Update WidgetBase, ChromeClient, tests, and more code accordingly. - Update RenderWidgetHostViewMac's cached display::Display on changes. - Add CoreInitializer plumbing to fire Screens.change in modules/. FOLLOWUP: Refine Screens::ScreenInfosChanged implementation. FOLLOWUP: Propagate multi-screen info to RemoteFrames. FOLLOWUP: Update/add tests; remove old API and plumbing. FOLLOWUP: Add WindowScreens PermissionObserver & set_disconnect_handler? FOLLOWUP: Use WebContentsImpl's NativeView in RWHI::GetScreenInfo? Bug: 897300, 1116528, 1138596, 1169312, 1116528, 1179876, 1179945 Test: New API roughly WAI w/ --enable-blink-features=WindowPlacement Change-Id: I1d67cfabda62796274992e3e650d5209dd7bb857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2669359 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#858379}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2669359
branch
from
5f2b0c0
to
c3ee902
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL makes the following changes for a planned API redesign:
docs.google.com/document/d/1lgCentReLlym6j9kBS_Qo3r2HHZ6Ov7cSGjSWyi8cYs
FOLLOWUP: Refine Screens::ScreenInfosChanged implementation.
FOLLOWUP: Propagate multi-screen info to RemoteFrames.
FOLLOWUP: Update/add tests; remove old API and plumbing.
FOLLOWUP: Add WindowScreens PermissionObserver & set_disconnect_handler?
FOLLOWUP: Use WebContentsImpl's NativeView in RWHI::GetScreenInfo?
Bug: 897300, 1116528, 1138596, 1169312, 1116528, 1179876, 1179945
Test: New API roughly WAI w/ --enable-blink-features=WindowPlacement
Change-Id: I1d67cfabda62796274992e3e650d5209dd7bb857
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2669359
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#858379}