Skip to content

ryujinx: 1.0.5551 -> 1.0.6416 #110812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2021
Merged

ryujinx: 1.0.5551 -> 1.0.6416 #110812

merged 1 commit into from
Jan 25, 2021
+82 −62

Conversation

IvarWithoutBones
Copy link
Member

Motivation for this change

This updates the Ryujinx package to the latest version, in which they have switch from dotnet_3_1 to net5.

The build spams warning NU3018, which i think is related to NuGet/Home#10328 and which i am not sure how to fix. It still builds and functions totally fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@IvarWithoutBones
ryujinx: 1.0.5551 -> 1.0.6416

Unverified

The committer email address is not verified.
Learn about vigilant mode
1f274be
@IvarWithoutBones
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2 label Jan 25, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 25, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the needs_reviewer (old Marvin label, do not use) label Jan 25, 2021
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 25, 2021
@SuperSandro2000 SuperSandro2000 merged commit a948db7 into NixOS:master Jan 25, 2021
@IvarWithoutBones IvarWithoutBones deleted the ryujinx-net5 branch January 25, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2 needs_reviewer (old Marvin label, do not use)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IvarWithoutBones @SuperSandro2000