nodePackages: regenerate with node2nix 1.9.0 #110813

svanderburg · 2021-01-25T19:38:33Z

This reverts commit 3cd3145.

Motivation for this change

Second attempt update to node2nix 1.9.0.

Things done

svanderburg · 2021-01-25T19:41:00Z

I still need to investigate the problem case as described in #110545, most likely caused by zigbee2mqtt

iblech · 2021-01-25T21:26:19Z

Sorry dear bot @ofborg, I'm following this pull request with interest, but I am unfortunately not qualified to contribute a review.

SuperSandro2000 · 2021-01-25T21:39:09Z

I still need to investigate the problem case as described in #110545, most likely caused by zigbee2mqtt

It is definitely zigbee2mqtt because this exact same problem happened once before.

When someone tries this with nixpkgs-review make sure to pass --eval local otherwise you are using ofborg results which do not have this problem.

pkgs/applications/networking/cluster/spacegun/default.nix

svanderburg · 2021-01-26T20:18:06Z

hmm the weird thing is, I just have successfully built zigbee2mqtt locally.

Also, the following evaluation:

nix-env -f . -qaP --xml --out-path --show-trace

works for me.

Hmm indeed I get a stack stackoverflow/infinite recursion when I run:

nix-review wip

SuperSandro2000 · 2021-01-27T17:19:50Z

You need to run nixpkgs-review pr 110813 --eval local otherwise the results by ofborg are used.

svanderburg · 2021-01-27T20:50:22Z

@SuperSandro2000 yes I know.

This is weird situation. I think this problem is not caused by infinite recursion, but most likely by recursing too deeply. Maybe this condition is triggered when we evaluate all derivations on a cold cache, but not an individual package or a sub set.

What I think might contribute to this problem is the store derivations of NPM package deployments -- basically all dependencies including transitive dependencies in the entire closure become a direct dependency of the package to be deployed. Sadly, I see more and more NPM projects that use a substantial amount of dependencies (mostly micro-packages with only single functions).

For example, I see many packages in the closure of zigbee that are very small, such as the isarray package, which people probably should not use.

The only way to break out of this cycle, is probably a partial upgrade in which some packages are deployed with node2nix 1.9.0 and some still with 1.8.0. A binary cache probably contributes to the fact that not everything needs to be evaluated.

The real solution, of course, would be to change node2nix to not generate such large store derivations. It is already on my drawing board. This is obviously something that requires quite a bit of rework that will cost some time.

turboMaCk · 2021-01-27T22:34:42Z

I almost hate myself for saying that but I think maybe it doesn't make sense to block all of this work on one package. It's easy for me to say that since I don't depend on it and neither I knew the tool prior to this discussion but..... I think we should at least consider the option of just simply marking it as a broken.

SuperSandro2000 · 2021-01-27T23:58:09Z

We can keep zigbee2mqtt on an old version for now or worst case we mark it broken.

svanderburg · 2021-01-28T08:58:46Z

I'll see if I can work out a gradual transition scenario

svanderburg · 2021-02-02T16:24:03Z

@SuperSandro2000 I have regenerated the entire package set against a more recent version of the master branch.

Moreover, I have left zigbee2mqtt out of the generation process -- it is still deployable, but it uses node2nix 1.8.0's node-env.nix. When I run nixpkgs-review locally, I don't seem to run into this evaluation error that suggests infinite recursion.

@turboMaCk can you also take another look at this PR? Since this is an high impact change, I could use a second pair of eyes.

@raboof Maybe you can check as well, since previously you have noticed the issue.

raboof · 2021-02-02T16:57:53Z

@raboof Maybe you can check as well, since previously you have noticed the issue.

I don't see it with this PR anymore, either!

turboMaCk · 2021-02-02T18:43:51Z

So I've ran nixpkgs-review pr 110813 --eval local (and waited :D)

There seems to be few problems still.

elmPackages (maintained by me btw) fails to build due to breaking changes in upstream
- /nix/store/gasb9j1ksfv21bv6y586lv9nljdyqz1m-node_elm-test-0.19.1-revision6.drv fails on patchBinwrap (elm specific thing we do) due to breaking change upstream
- /nix/store/dlkl5yiam0cdg7ij5m8jl7zg6y0zhh7y-node_elm-review-2.4.0.drv fails due to the same reason
- /nix/store/xs9jn1hvqd62s2k5sw58lpgvwy66gm7z-node_create-elm-app-5.22.0.drv also fails for the same reason
matrix-appservice-slack fails during npm run build
vscode-lldb fails because of dependency build failing - likely unrelated
sage failed due to segfault in tests

$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/110813/head:refs/nixpkgs-review/1
$ git worktree add /home/marek/.cache/nixpkgs-review/pr-110813-2/nixpkgs fab6fcdceb2560a4ab943830a2b1632458c7a6ff
Preparing worktree (detached HEAD fab6fcdceb2)
Updating files: 100% (24290/24290), done.
HEAD is now at fab6fcdceb2 sbt-extras: 2020-12-26 → 2021-02-01
$ nix-env -f /home/marek/.cache/nixpkgs-review/pr-110813-2/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 8ba7dfad5cbd230f077e3205e572bacbe236c6ba
Removing pkgs/applications/networking/cluster/spacegun/package.json
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/marek/.cache/nixpkgs-review/pr-110813-2/nixpkgs -qaP --xml --out-path --show-trace --meta
136 packages updated:
airfield bat-extras-prettybat bitwarden-cli emojione EPGStation etcher imgbrd-grabber iosevka ldgallery lumo nixui node_base16-builder node_castnow node_create-cycle-app elmPackages.create-elm-app (5.21.0 → 5.22.0) node_cryptpad node_dat node_elm-analyse node_elm-coverage elmPackages.elm-doc-preview (5.0.3 → 5.0.5) node_elm-live node_elm-optimize-level elmPackages.elm-review (2.3.3 → 2.4.0) elmPackages.elm-test (0.19.1-revision4 → 0.19.1-revision6) node_elm-upgrade node_elm-verify-examples node_elm-xref node_fast-cli flood (4.3.1 → 4.4.0) node_fx node_gtop node_hueadm node_imapnotify node_joplin lessc (4.1.0 → 4.1.1) node_mastodon-bot node_matrix-appservice-slack node_mirakurun n8n (0.96.0 → 0.105.0) netlify-cli (3.4.3 → 3.4.6) newman (5.2.1 → 5.2.2) pm2 (4.5.1 → 4.5.4) node_postcss-cli node_pscid node_pulp node_purescript-psa redoc-cli (0.10.2 → 0.10.3) node_shout node_sloc node_spacegun node_thelounge node_triton node_whitebophir node_wring node_yaml-language-server node__at_antora_slash_cli elmPackages.elm-language-server (1.13.2 → 2.0.2) node__at_google_slash_clasp node__at_webassemblyjs_slash_cli node__at_webassemblyjs_slash_repl node__at_webassemblyjs_slash_wasm-strip node__at_webassemblyjs_slash_wasm-text-gen node__at_webassemblyjs_slash_wast-refmt parity-ui python3.7-batchspawner python3.7-dockerspawner python3.7-jupyterhub python3.7-jupyterhub-ldapauthenticator python3.7-jupyterhub-systemdspawner python3.7-jupyterhub-tmpauthenticator python3.7-oauthenticator python3.8-batchspawner python3.8-dockerspawner python3.8-jupyterhub python3.8-jupyterhub-ldapauthenticator python3.8-jupyterhub-systemdspawner python3.8-jupyterhub-tmpauthenticator python3.8-oauthenticator python3.9-batchspawner python3.9-dockerspawner python3.9-jupyterhub python3.9-jupyterhub-ldapauthenticator python3.9-jupyterhub-systemdspawner python3.9-jupyterhub-tmpauthenticator python3.9-oauthenticator remarkjs ripcord sage sage sage slack slack styx teleprompter twemoji-color-font uchiwa vimplugin-coc-css vimplugin-coc-diagnostic vimplugin-coc-emmet vimplugin-coc-eslint vimplugin-coc-git vimplugin-coc-go vimplugin-coc-highlight vimplugin-coc-html vimplugin-coc-imselect vimplugin-coc-java vimplugin-coc-jest vimplugin-coc-json vimplugin-coc-lists vimplugin-coc-markdownlint vimplugin-coc-metals vimplugin-coc-pairs vimplugin-coc-prettier vimplugin-coc-python vimplugin-coc-r-lsp vimplugin-coc-rls vimPlugins.coc-rust-analyzer (0.30.0 → 0.31.0) vimplugin-coc-smartf vimplugin-coc-snippets vimplugin-coc-solargraph vimplugin-coc-stylelint vimplugin-coc-tabnine vimplugin-coc-tslint vimplugin-coc-tslint-plugin vimplugin-coc-tsserver vimplugin-coc-vetur vimplugin-coc-vimlsp vimplugin-coc-vimtex vimplugin-coc-wxml vimplugin-coc-yaml vimplugin-coc-yank vimplugin-YouCompleteMe vscode-extension-MS-python-vscode-pylance vscode-extension-rust-analyzer-unstable vscode-extension-vscode-lldb ycmd

$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/marek/.cache/nixpkgs-review/pr-110813-2/build.nix
builder for '/nix/store/gasb9j1ksfv21bv6y586lv9nljdyqz1m-node_elm-test-0.19.1-revision6.drv' failed with exit code 1; last 10 log lines:
  npm WARN optional SKIPPING OPTIONAL DEPENDENCY: xml2js@0.4.23 (node_modules/xml2js):
  npm WARN optional SKIPPING OPTIONAL DEPENDENCY: request to https://registry.npmjs.org/xml2js failed: cache mode is 'only-if-cached' but no cached response available.
  
  up to date in 0.844s
  
  5 packages are looking for funding
    run `npm fund` for details
  
  linking elmi-to-json
  ln: failed to create symbolic link 'node_modules/elmi-to-json/bin/elmi-to-json': No such file or directory
builder for '/nix/store/dlkl5yiam0cdg7ij5m8jl7zg6y0zhh7y-node_elm-review-2.4.0.drv' failed with exit code 1; last 10 log lines:
  npm WARN optional SKIPPING OPTIONAL DEPENDENCY: xo@^0.33.0 (node_modules/xo):
  npm WARN optional SKIPPING OPTIONAL DEPENDENCY: request to https://registry.npmjs.org/xo failed: cache mode is 'only-if-cached' but no cached response available.
  
  up to date in 1.609s
  
  17 packages are looking for funding
    run `npm fund` for details
  
  linking elm-json
  ln: failed to create symbolic link 'node_modules/elm-json/bin/elm-json': No such file or directory
builder for '/nix/store/qi2dc7n8345dzr4xpa1izarirsnjhinw-node_matrix-appservice-slack-1.4.0.drv' failed with exit code 2; last 10 log lines:
  npm ERR! errno 2
  npm ERR! matrix-appservice-slack@1.4.0 prepare: `npm run build`
  npm ERR! Exit status 2
  npm ERR! 
  npm ERR! Failed at the matrix-appservice-slack@1.4.0 prepare script.
  npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
  
  npm ERR! A complete log of this run can be found in:
  npm ERR!     /build/.npm/_logs/2021-02-02T17_01_14_195Z-debug.log
  
builder for '/nix/store/xs9jn1hvqd62s2k5sw58lpgvwy66gm7z-node_create-elm-app-5.22.0.drv' failed with exit code 1; last 10 log lines:
  npm WARN optional SKIPPING OPTIONAL DEPENDENCY: request to https://registry.npmjs.org/unexpected failed: cache mode is 'only-if-cached' but no cached response available.
  npm WARN autoprefixer@10.1.0 requires a peer of postcss@^8.1.0 but none is installed. You must install peer dependencies yourself.
  
  up to date in 12.872s
  
  61 packages are looking for funding
    run `npm fund` for details
  
  linking elmi-to-json
  ln: failed to create symbolic link 'node_modules/elmi-to-json/bin/elmi-to-json': No such file or directory
builder for '/nix/store/nz24mhs18vadzw1q6ljzvxxhcd3lmhmi-vscode-lldb-adapter-1.5.3.drv' failed with exit code 101; last 10 log lines:
  For more information about this error, try `rustc --explain E0277`.
  The following warnings were emitted during compilation:
  
  warning: Could not find CMakeCache.txt
  
  error: could not compile `lldb`
  
  To learn more, run the command again with --verbose.
  warning: build failed, waiting for other jobs to finish...
  error: build failed
cannot build derivation '/nix/store/wlfk2q8q2l9kb56dyf955ygjbsckgmfh-vscode-lldb-1.5.3-vsix.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/x9wyv5bvg01zzybz8wfwpl5plx11pvx0-vscode-extension-vscode-lldb.drv': 1 dependencies couldn't be built
builder for '/nix/store/xm4x8gx5nzisig0ablf1a17hz7gka9p7-sage-tests-9.2.drv' failed with exit code 17; last 10 log lines:
  ----------------------------------------------------------------------t
  sage -t --long --random-seed=0 /nix/store/kc7cf6p4z8qm7hppw40kazlwyv54p2fr-sage-src-9.2/src/sage/interfaces/singular.py  # Killed due to segmentation fault
  sage -t --long --random-seed=0 /nix/store/kc7cf6p4z8qm7hppw40kazlwyv54p2fr-sage-src-9.2/src/sage/plot/plot3d/base.pyx  # 11 doctests failed
  sage -t --long --random-seed=0 /nix/store/kc7cf6p4z8qm7hppw40kazlwyv54p2fr-sage-src-9.2/src/sage/plot/animate.py  # 2 doctests failed
  sage -t --long --random-seed=0 /nix/store/kc7cf6p4z8qm7hppw40kazlwyv54p2fr-sage-src-9.2/src/sage/repl/rich_output/backend_ipython.py  # 1 doctest failed
  sage -t --long --random-seed=0 /nix/store/kc7cf6p4z8qm7hppw40kazlwyv54p2fr-sage-src-9.2/src/sage/repl/rich_output/display_manager.py  # 1 doctest failed
  ----------------------------------------------------------------------
  Total time for all tests: 2026.6 seconds
      cpu time: 17888.5 seconds
      cumulative wall time: 25844.6 seconds
cannot build derivation '/nix/store/nw6afad4d7nhwhrxrs4r23dwsm5h40p8-sage-9.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/x8079n1y6b9awabwiqafqirfaqkv879s-sage-9.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/m7mxch2vyklbiz5nxyfa7744pby97cwz-env.drv': 7 dependencies couldn't be built
error: --- Error ------------------------------------------------------------------------------------------------------------------------------------------------------- nix
build of '/nix/store/m7mxch2vyklbiz5nxyfa7744pby97cwz-env.drv' failed

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/110813

3 packages marked as broken and skipped:
dat remarkjs vimPlugins.coc-imselect

7 packages failed to build:
elmPackages.create-elm-app elmPackages.elm-review elmPackages.elm-test matrix-appservice-slack sage sageWithDoc vscode-extensions.vadimcn.vscode-lldb

124 packages built:
airfield antora base16-builder bat-extras.prettybat bitwarden-cli castnow create-cycle-app cryptpad elmPackages.elm-analyse elmPackages.elm-coverage elmPackages.elm-doc-preview elmPackages.elm-language-server elmPackages.elm-live elmPackages.elm-optimize-level-2 elmPackages.elm-upgrade elmPackages.elm-verify-examples elmPackages.elm-xref emojione epgstation etcher fast-cli flood fx google-clasp gtop hueadm imapnotify imgbrd-grabber iosevka joplin ldgallery lessc lumo mastodon-bot mirakurun n8n netlify-cli newman nixui parity-ui pm2 postcss-cli pscid pulp purescript-psa python37Packages.batchspawner python37Packages.dockerspawner python37Packages.jupyterhub python37Packages.jupyterhub-ldapauthenticator python37Packages.jupyterhub-systemdspawner python37Packages.jupyterhub-tmpauthenticator python37Packages.oauthenticator python38Packages.batchspawner python38Packages.dockerspawner python38Packages.jupyterhub python38Packages.jupyterhub-ldapauthenticator python38Packages.jupyterhub-systemdspawner python38Packages.jupyterhub-tmpauthenticator python38Packages.oauthenticator python39Packages.batchspawner python39Packages.dockerspawner python39Packages.jupyterhub python39Packages.jupyterhub-ldapauthenticator python39Packages.jupyterhub-systemdspawner python39Packages.jupyterhub-tmpauthenticator python39Packages.oauthenticator redoc-cli ripcord shout slack sloc spacegun styx teleprompter thelounge triton twemoji-color-font uchiwa vimPlugins.YouCompleteMe vimPlugins.coc-css vimPlugins.coc-diagnostic vimPlugins.coc-emmet vimPlugins.coc-eslint vimPlugins.coc-git vimPlugins.coc-go vimPlugins.coc-highlight vimPlugins.coc-html vimPlugins.coc-java vimPlugins.coc-jest vimPlugins.coc-json vimPlugins.coc-lists vimPlugins.coc-markdownlint vimPlugins.coc-metals vimPlugins.coc-pairs vimPlugins.coc-prettier vimPlugins.coc-python vimPlugins.coc-r-lsp vimPlugins.coc-rls vimPlugins.coc-rust-analyzer vimPlugins.coc-smartf vimPlugins.coc-snippets vimPlugins.coc-solargraph vimPlugins.coc-stylelint vimPlugins.coc-tabnine vimPlugins.coc-tslint vimPlugins.coc-tslint-plugin vimPlugins.coc-tsserver vimPlugins.coc-vetur vimPlugins.coc-vimlsp vimPlugins.coc-vimtex vimPlugins.coc-wxml vimPlugins.coc-yaml vimPlugins.coc-yank vscode-extensions.matklad.rust-analyzer vscode-extensions.ms-python.vscode-pylance wasm-strip wasm-text-gen wast-refmt webassemblyjs-cli webassemblyjs-repl whitebophir wring yaml-language-server ycmd

error: --- Error ------------------------------------------------------------------------------------------------------------------------------------------------------- nix
build log of '/nix/store/9rggvly206hpc9b9k4h3qp0xj18lfl7k-lumo-1.10.1.drv' is not available
error: --- Error ------------------------------------------------------------------------------------------------------------------------------------------------------- nix
build log of '/nix/store/nw6afad4d7nhwhrxrs4r23dwsm5h40p8-sage-9.2.drv' is not available
error: --- Error ------------------------------------------------------------------------------------------------------------------------------------------------------- nix
build log of '/nix/store/x8079n1y6b9awabwiqafqirfaqkv879s-sage-9.2.drv' is not available
error: --- Error ------------------------------------------------------------------------------------------------------------------------------------------------------- nix
build log of '/nix/store/x9wyv5bvg01zzybz8wfwpl5plx11pvx0-vscode-extension-vscode-lldb.drv' is not available
$ nix-shell /home/marek/.cache/nixpkgs-review/pr-110813-2/shell.nix
these 4 paths will be fetched (0.51 MiB download, 2.47 MiB unpacked):
  /nix/store/7j4fadgmhydwa3k89zddqmk5sh8swfwz-bash-interactive-4.4-p23-man
  /nix/store/bgn5j1x94ynfs3kpi0wdhzd9xi45c8ab-bash-interactive-4.4-p23-info
  /nix/store/dx9ghdnwi1bpxjc250rkhpzzfs6y1nix-bash-interactive-4.4-p23-doc
  /nix/store/wa5xkjha3zxiqljnb2mp1ym9z4w07djp-bash-interactive-4.4-p23-dev
copying path '/nix/store/dx9ghdnwi1bpxjc250rkhpzzfs6y1nix-bash-interactive-4.4-p23-doc' from 'https://cache.nixos.org'...
copying path '/nix/store/bgn5j1x94ynfs3kpi0wdhzd9xi45c8ab-bash-interactive-4.4-p23-info' from 'https://cache.nixos.org'...
copying path '/nix/store/7j4fadgmhydwa3k89zddqmk5sh8swfwz-bash-interactive-4.4-p23-man' from 'https://cache.nixos.org'...
copying path '/nix/store/wa5xkjha3zxiqljnb2mp1ym9z4w07djp-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...

For elmPackages I'm aware of the breaking changes in upstream from #110845. I would suggest to reset/revert the changes - I'll take care of them in separate PR. I also need to sync with upstreams on a few things.

I'm not sure about the rest though. Let me know if I could help you with this further.

svanderburg · 2021-02-02T19:15:48Z

@turboMaCk I just fixed the matrix-appservice-slack package by using a different generation strategy. I'm still investigating the others.

About reverting changes -- do you mean reverting the changes that are related to the Elm packages?

svanderburg · 2021-02-02T20:50:22Z

hmm it closed all of a sudden :(

svanderburg · 2021-02-02T20:54:28Z

@turboMaCk I reverted the elm/ commits. I hope it evaluates now, there was a package named: galene that was still using the old deprecated stdenv.lib reference.

turboMaCk · 2021-02-02T21:05:39Z

@svanderburg I've actually tested it locally before posting the reply and nix-build -A elmPackages just went through straight from the cache so 🤞

I'll also let nixpkgs-review ran again (this time even my old macbook pro to see how this does on Darwin) probably over the night if it wil take too long. But I think this is 👍 from my side at least.

svanderburg · 2021-02-02T21:11:45Z

@turboMaCk I also briefly checked the other two packages that did not build, but they fail because some tool (that has an NPM package as a dependency) in the build process fails, with a segfault.

Although I can't be 100% sure, I think it's very unlikely that it was caused by an NPM dependency upgrade. It looks like sage (a project that is compiled with gcc) segfaults.

turboMaCk

This is the result of nixpkgs-review on nixos:

nixpkgs-review pr 110813 --eval local
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/110813/head:refs/nixpkgs-review/1
remote: Enumerating objects: 157, done.
remote: Counting objects: 100% (157/157), done.
remote: Compressing objects: 100% (18/18), done.
remote: Total 205 (delta 142), reused 147 (delta 137), pack-reused 48
Receiving objects: 100% (205/205), 143.80 KiB | 871.00 KiB/s, done.
Resolving deltas: 100% (143/143), completed with 91 local objects.
From https://github.com/NixOS/nixpkgs
   410bbd828cd..c0974f36049  master                -> refs/nixpkgs-review/0
 + 8ba7dfad5cb...9c6cafc820c refs/pull/110813/head -> refs/nixpkgs-review/1  (forced update)
$ git worktree add /home/marek/.cache/nixpkgs-review/pr-110813-4/nixpkgs c0974f3604980e548607ad2587d267b0a74bb932
Preparing worktree (detached HEAD c0974f36049)
Updating files: 100% (24297/24297), done.
HEAD is now at c0974f36049 Merge pull request #111669 from apeyroux/up-masterpdf-5720
$ nix-env -f /home/marek/.cache/nixpkgs-review/pr-110813-4/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 9c6cafc820c547107a33c3f9057c08033c30be36
Removing pkgs/servers/matrix-synapse/matrix-appservice-slack/package.json
Removing pkgs/applications/networking/cluster/spacegun/package.json
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/marek/.cache/nixpkgs-review/pr-110813-4/nixpkgs -qaP --xml --out-path --show-trace --meta
124 packages updated:
airfield bat-extras-prettybat bitwarden-cli emojione EPGStation etcher imgbrd-grabber iosevka ldgallery lumo nixui node_base16-builder node_castnow node_create-cycle-app node_cryptpad node_dat node_fast-cli flood (4.3.1 → 4.4.0) node_fx node_gtop node_hueadm node_imapnotify node_joplin lessc (4.1.0 → 4.1.1) node_mastodon-bot node_matrix-appservice-slack node_mirakurun n8n (0.96.0 → 0.105.0) netlify-cli (3.4.3 → 3.4.6) newman (5.2.1 → 5.2.2) pm2 (4.5.1 → 4.5.4) node_postcss-cli node_pscid node_pulp node_purescript-psa redoc-cli (0.10.2 → 0.10.3) node_shout node_sloc node_spacegun node_thelounge node_triton node_whitebophir node_wring node_yaml-language-server node__at_antora_slash_cli node__at_google_slash_clasp node__at_webassemblyjs_slash_cli node__at_webassemblyjs_slash_repl node__at_webassemblyjs_slash_wasm-strip node__at_webassemblyjs_slash_wasm-text-gen node__at_webassemblyjs_slash_wast-refmt parity-ui python3.7-batchspawner python3.7-dockerspawner python3.7-jupyterhub python3.7-jupyterhub-ldapauthenticator python3.7-jupyterhub-systemdspawner python3.7-jupyterhub-tmpauthenticator python3.7-oauthenticator python3.8-batchspawner python3.8-dockerspawner python3.8-jupyterhub python3.8-jupyterhub-ldapauthenticator python3.8-jupyterhub-systemdspawner python3.8-jupyterhub-tmpauthenticator python3.8-oauthenticator python3.9-batchspawner python3.9-dockerspawner python3.9-jupyterhub python3.9-jupyterhub-ldapauthenticator python3.9-jupyterhub-systemdspawner python3.9-jupyterhub-tmpauthenticator python3.9-oauthenticator remarkjs ripcord sage sage sage slack slack styx teleprompter twemoji-color-font uchiwa vimplugin-coc-css vimplugin-coc-diagnostic vimplugin-coc-emmet vimplugin-coc-eslint vimplugin-coc-git vimplugin-coc-go vimplugin-coc-highlight vimplugin-coc-html vimplugin-coc-imselect vimplugin-coc-java vimplugin-coc-jest vimplugin-coc-json vimplugin-coc-lists vimplugin-coc-markdownlint vimplugin-coc-metals vimplugin-coc-pairs vimplugin-coc-prettier vimplugin-coc-python vimplugin-coc-r-lsp vimplugin-coc-rls vimPlugins.coc-rust-analyzer (0.30.0 → 0.31.0) vimplugin-coc-smartf vimplugin-coc-snippets vimplugin-coc-solargraph vimplugin-coc-stylelint vimplugin-coc-tabnine vimplugin-coc-tslint vimplugin-coc-tslint-plugin vimplugin-coc-tsserver vimplugin-coc-vetur vimplugin-coc-vimlsp vimplugin-coc-vimtex vimplugin-coc-wxml vimplugin-coc-yaml vimplugin-coc-yank vimplugin-YouCompleteMe vscode-extension-MS-python-vscode-pylance vscode-extension-rust-analyzer-unstable vscode-extension-vscode-lldb ycmd

$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/marek/.cache/nixpkgs-review/pr-110813-4/build.nix
builder for '/nix/store/nz24mhs18vadzw1q6ljzvxxhcd3lmhmi-vscode-lldb-adapter-1.5.3.drv' failed with exit code 101; last 10 log lines:
  For more information about this error, try `rustc --explain E0277`.
  The following warnings were emitted during compilation:
  
  warning: Could not find CMakeCache.txt
  
  error: could not compile `lldb`
  
  To learn more, run the command again with --verbose.
  warning: build failed, waiting for other jobs to finish...
  error: build failed
cannot build derivation '/nix/store/wlfk2q8q2l9kb56dyf955ygjbsckgmfh-vscode-lldb-1.5.3-vsix.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/x9wyv5bvg01zzybz8wfwpl5plx11pvx0-vscode-extension-vscode-lldb.drv': 1 dependencies couldn't be built
builder for '/nix/store/xm4x8gx5nzisig0ablf1a17hz7gka9p7-sage-tests-9.2.drv' failed with exit code 1; last 10 log lines:
      [13 tests, 352.44 s]
  ----------------------------------------------------------------------
  sage -t --long --random-seed=0 /nix/store/kc7cf6p4z8qm7hppw40kazlwyv54p2fr-sage-src-9.2/src/sage/plot/plot3d/base.pyx  # 11 doctests failed
  sage -t --long --random-seed=0 /nix/store/kc7cf6p4z8qm7hppw40kazlwyv54p2fr-sage-src-9.2/src/sage/plot/animate.py  # 2 doctests failed
  sage -t --long --random-seed=0 /nix/store/kc7cf6p4z8qm7hppw40kazlwyv54p2fr-sage-src-9.2/src/sage/repl/rich_output/backend_ipython.py  # 1 doctest failed
  sage -t --long --random-seed=0 /nix/store/kc7cf6p4z8qm7hppw40kazlwyv54p2fr-sage-src-9.2/src/sage/repl/rich_output/display_manager.py  # 1 doctest failed
  ----------------------------------------------------------------------
  Total time for all tests: 1605.9 seconds
      cpu time: 17281.0 seconds
      cumulative wall time: 19924.2 seconds
cannot build derivation '/nix/store/nw6afad4d7nhwhrxrs4r23dwsm5h40p8-sage-9.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/x8079n1y6b9awabwiqafqirfaqkv879s-sage-9.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/m5i1px9c29c7cgaxnkkgdvxsah4qvawk-env.drv': 3 dependencies couldn't be built
error: --- Error ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- nix
build of '/nix/store/m5i1px9c29c7cgaxnkkgdvxsah4qvawk-env.drv' failed

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/110813

3 packages marked as broken and skipped:
dat remarkjs vimPlugins.coc-imselect

3 packages failed to build:
sage sageWithDoc vscode-extensions.vadimcn.vscode-lldb

116 packages built:
airfield antora base16-builder bat-extras.prettybat bitwarden-cli castnow create-cycle-app cryptpad emojione epgstation etcher fast-cli flood fx google-clasp gtop hueadm imapnotify imgbrd-grabber iosevka joplin ldgallery lessc lumo mastodon-bot matrix-appservice-slack mirakurun n8n netlify-cli newman nixui parity-ui pm2 postcss-cli pscid pulp purescript-psa python37Packages.batchspawner python37Packages.dockerspawner python37Packages.jupyterhub python37Packages.jupyterhub-ldapauthenticator python37Packages.jupyterhub-systemdspawner python37Packages.jupyterhub-tmpauthenticator python37Packages.oauthenticator python38Packages.batchspawner python38Packages.dockerspawner python38Packages.jupyterhub python38Packages.jupyterhub-ldapauthenticator python38Packages.jupyterhub-systemdspawner python38Packages.jupyterhub-tmpauthenticator python38Packages.oauthenticator python39Packages.batchspawner python39Packages.dockerspawner python39Packages.jupyterhub python39Packages.jupyterhub-ldapauthenticator python39Packages.jupyterhub-systemdspawner python39Packages.jupyterhub-tmpauthenticator python39Packages.oauthenticator redoc-cli ripcord shout slack sloc spacegun styx teleprompter thelounge triton twemoji-color-font uchiwa vimPlugins.YouCompleteMe vimPlugins.coc-css vimPlugins.coc-diagnostic vimPlugins.coc-emmet vimPlugins.coc-eslint vimPlugins.coc-git vimPlugins.coc-go vimPlugins.coc-highlight vimPlugins.coc-html vimPlugins.coc-java vimPlugins.coc-jest vimPlugins.coc-json vimPlugins.coc-lists vimPlugins.coc-markdownlint vimPlugins.coc-metals vimPlugins.coc-pairs vimPlugins.coc-prettier vimPlugins.coc-python vimPlugins.coc-r-lsp vimPlugins.coc-rls vimPlugins.coc-rust-analyzer vimPlugins.coc-smartf vimPlugins.coc-snippets vimPlugins.coc-solargraph vimPlugins.coc-stylelint vimPlugins.coc-tabnine vimPlugins.coc-tslint vimPlugins.coc-tslint-plugin vimPlugins.coc-tsserver vimPlugins.coc-vetur vimPlugins.coc-vimlsp vimPlugins.coc-vimtex vimPlugins.coc-wxml vimPlugins.coc-yaml vimPlugins.coc-yank vscode-extensions.matklad.rust-analyzer vscode-extensions.ms-python.vscode-pylance wasm-strip wasm-text-gen wast-refmt webassemblyjs-cli webassemblyjs-repl whitebophir wring yaml-language-server ycmd

error: --- Error ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- nix
build log of '/nix/store/9rggvly206hpc9b9k4h3qp0xj18lfl7k-lumo-1.10.1.drv' is not available
error: --- Error ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- nix
build log of '/nix/store/nw6afad4d7nhwhrxrs4r23dwsm5h40p8-sage-9.2.drv' is not available
error: --- Error ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- nix
build log of '/nix/store/x8079n1y6b9awabwiqafqirfaqkv879s-sage-9.2.drv' is not available
error: --- Error ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- nix
build log of '/nix/store/x9wyv5bvg01zzybz8wfwpl5plx11pvx0-vscode-extension-vscode-lldb.drv' is not available
$ nix-shell /home/marek/.cache/nixpkgs-review/pr-110813-4/shell.nix

I also think these are most likely unrelated failures. MacOS build is still running since it's much weaker hw. So far the only unexpected thing is failure of ldgallery-viewer there but I think that's most likely not a regression.

Overall I think this PR is more than good enough considering the scope. I really appreciate the effort! From my side it's LGTM.

svanderburg · 2021-02-02T22:50:48Z

@turboMaCk Thank you for all the assistance! I believe in the previous PR (that we reverted) we came to the same conclusion that the ldgallery/viewer package was already broken on Darwin.

I'll wait until tomorrow, so that people still have the opportunity to respond. Hopefully, nothing in the master branch will conflict in the meantime.

I also have to give node2nix some more thought on how to deal with these problematic packages, such as zigbee2mqtt. Sadly, the generation technique that I'm currently using has its limits, in particular on projects with 20K+ dependencies, and many levels of dependencies. This seems to become more common these days -- I think NPM can be considered a solution that automates code copy-and-pasting, that we used to do manually from Stackoverflow in the past.

Because NPM works so well, people are installing more and more package dependencies in projects (and those packages do the same) causing explosions of dependencies.

Probably in the near future, we may run into more weird limitations that the Nix package manager/Nix expression languages has difficulties coping with. That's why I think we have to be careful with adding new NPM projects to Nixpkgs, until I found a better to deal with these big/complex projects. This is still ongoing research.

turboMaCk · 2021-02-02T23:05:55Z

@ofborg eval

SuperSandro2000 · 2021-02-03T13:05:18Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110813 run on x86_64-darwin 1

1 package marked as broken and skipped:

nixui

1 package failed to build and already failed to build on hydra master:

ldgallery: log was empty

1 package failed to build and are new build failure:

tests.writers: log was empty

28 packages built:

bat-extras.prettybat
python37Packages.batchspawner
python37Packages.dockerspawner
python37Packages.jupyterhub
python37Packages.jupyterhub-ldapauthenticator
python37Packages.jupyterhub-systemdspawner
python37Packages.jupyterhub-tmpauthenticator
python37Packages.oauthenticator
python38Packages.batchspawner
python38Packages.dockerspawner
python38Packages.jupyterhub
python38Packages.jupyterhub-ldapauthenticator
python38Packages.jupyterhub-systemdspawner
python38Packages.jupyterhub-tmpauthenticator
python38Packages.oauthenticator
python39Packages.batchspawner
python39Packages.dockerspawner
python39Packages.jupyterhub
python39Packages.jupyterhub-ldapauthenticator
python39Packages.jupyterhub-systemdspawner
python39Packages.jupyterhub-tmpauthenticator
python39Packages.oauthenticator
styx
uchiwa
vimPlugins.YouCompleteMe
vscode-extensions.matklad.rust-analyzer
whitebophir
ycmd

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.jupyterhub-systemdspawner:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

python37Packages.jupyterhub:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern ''npm', 'run', 'lessc', '--'' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

python38Packages.jupyterhub-systemdspawner:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

python38Packages.jupyterhub:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern ''npm', 'run', 'lessc', '--'' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

python39Packages.jupyterhub-systemdspawner:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

python39Packages.jupyterhub:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern ''npm', 'run', 'lessc', '--'' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

ycmd:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern '/nix/store/nahdkr6gb1717grd0yqbnnas7z5wsfnn-ycmd-2020-02-22/lib/ycmd/ycmd/__main__.py' doesn't match anything in file '/nix/store/nahdkr6gb1717grd0yqbnnas7z5wsfnn-ycmd-2020-02-22/lib/ycmd/ycmd/__main__.py'

Please check the offending substituteInPlace for typos or changes in source.
warning: missing-phase-hooks
buildPhase should probably contain runHook preBuild and runHook postBuild.

Near pkgs/development/tools/misc/ycmd/default.nix:26:3:

   |
26 |   buildPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.

Near pkgs/development/tools/misc/ycmd/default.nix:43:3:

   |
43 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
warning: unclear-gpl
gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

Near pkgs/development/tools/misc/ycmd/default.nix:96:5:

   |
96 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

svanderburg · 2021-02-03T14:55:02Z

@SuperSandro2000 Looks like the output matches our expectation. The only exception is the failing writers test -- the fact that it fails with a log was empty error may have been caused by a problem with the build infrastructure. Not sure, if we can redo that build.

The rest (I believe) should not cause any problems.

SuperSandro2000 · 2021-02-03T16:57:04Z

I have blacklisted writers test in nixpkgs-review. The other things are expected.

SuperSandro2000 · 2021-02-03T17:50:21Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110813 run on x86_64-linux 1

3 packages marked as broken and skipped:

image_optim
remarkjs
vimPlugins.coc-imselect

1 package blacklisted:

tests.writers

1 package failed to build and are new build failure:

vscode-extensions.vadimcn.vscode-lldb: log was empty

114 packages built:

airfield
antora
base16-builder
bat-extras.prettybat
bitwarden-cli
castnow
create-cycle-app
cryptpad
emojione
epgstation
etcher
fast-cli
flood
fx
google-clasp
gtop
hueadm
imapnotify
imgbrd-grabber
joplin
ldgallery
lessc
mastodon-bot
matrix-appservice-slack
mirakurun
n8n
netlify-cli
newman
nixui
parity-ui
pm2
postcss-cli
pscid
pulp
purescript-psa
python37Packages.batchspawner
python37Packages.dockerspawner
python37Packages.jupyterhub
python37Packages.jupyterhub-ldapauthenticator
python37Packages.jupyterhub-systemdspawner
python37Packages.jupyterhub-tmpauthenticator
python37Packages.oauthenticator
python38Packages.batchspawner
python38Packages.dockerspawner
python38Packages.jupyterhub
python38Packages.jupyterhub-ldapauthenticator
python38Packages.jupyterhub-systemdspawner
python38Packages.jupyterhub-tmpauthenticator
python38Packages.oauthenticator
python39Packages.batchspawner
python39Packages.dockerspawner
python39Packages.jupyterhub
python39Packages.jupyterhub-ldapauthenticator
python39Packages.jupyterhub-systemdspawner
python39Packages.jupyterhub-tmpauthenticator
python39Packages.oauthenticator
redoc-cli
ripcord
shout
slack
sloc
spacegun
styx
teleprompter
thelounge
triton
twemoji-color-font
uchiwa
vimPlugins.YouCompleteMe
vimPlugins.coc-css
vimPlugins.coc-diagnostic
vimPlugins.coc-emmet
vimPlugins.coc-eslint
vimPlugins.coc-git
vimPlugins.coc-go
vimPlugins.coc-highlight
vimPlugins.coc-html
vimPlugins.coc-java
vimPlugins.coc-jest
vimPlugins.coc-json
vimPlugins.coc-lists
vimPlugins.coc-markdownlint
vimPlugins.coc-metals
vimPlugins.coc-pairs
vimPlugins.coc-prettier
vimPlugins.coc-python
vimPlugins.coc-r-lsp
vimPlugins.coc-rls
vimPlugins.coc-rust-analyzer
vimPlugins.coc-smartf
vimPlugins.coc-snippets
vimPlugins.coc-solargraph
vimPlugins.coc-stylelint
vimPlugins.coc-tabnine
vimPlugins.coc-tslint
vimPlugins.coc-tslint-plugin
vimPlugins.coc-tsserver
vimPlugins.coc-vetur
vimPlugins.coc-vimlsp
vimPlugins.coc-vimtex
vimPlugins.coc-wxml
vimPlugins.coc-yaml
vimPlugins.coc-yank
vscode-extensions.matklad.rust-analyzer
vscode-extensions.ms-python.vscode-pylance
wasm-strip
wasm-text-gen
wast-refmt
webassemblyjs-cli
webassemblyjs-repl
whitebophir
wring
yaml-language-server
ycmd

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.jupyterhub:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern ''npm', 'run', 'lessc', '--'' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

python37Packages.jupyterhub-systemdspawner:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

python38Packages.jupyterhub:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern ''npm', 'run', 'lessc', '--'' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

python38Packages.jupyterhub-systemdspawner:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

python39Packages.jupyterhub:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern ''npm', 'run', 'lessc', '--'' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

python39Packages.jupyterhub-systemdspawner:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

ycmd:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern '/nix/store/p35vawy3d8ghgbqncksl9d8dqv47p5wk-ycmd-2020-02-22/lib/ycmd/ycmd/__main__.py' doesn't match anything in file '/nix/store/p35vawy3d8ghgbqncksl9d8dqv47p5wk-ycmd-2020-02-22/lib/ycmd/ycmd/__main__.py'

Please check the offending substituteInPlace for typos or changes in source.
warning: unclear-gpl
gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

Near pkgs/development/tools/misc/ycmd/default.nix:96:5:

   |
96 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: missing-phase-hooks
buildPhase should probably contain runHook preBuild and runHook postBuild.

Near pkgs/development/tools/misc/ycmd/default.nix:26:3:

   |
26 |   buildPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.

Near pkgs/development/tools/misc/ycmd/default.nix:43:3:

   |
43 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

SuperSandro2000 · 2021-02-03T18:06:54Z

pkgs/stdenv/generic/default.nix

@@ -153,7 +153,7 @@ let
      }) mkDerivation;

      # Slated for deprecation in 21.11
-      lib = builtins.trace
+      lib = throw #builtins.trace


This needs to be reverted.

svanderburg · 2021-02-03T18:55:35Z

@SuperSandro2000 I just reverted that change (I did an amend/force push to make sure it won't get into master in by accident).

We also briefly encountered that problem with the vscode-extensions.vadimcn.vscode-lldb package. It's indirectly caused by sage that segfaults in the build process of the plugin. A node package is an indirect dependency of it. Not sure, if there's a direct correlation between them.

svanderburg · 2021-02-03T18:59:59Z

Anyway, I think we have pretty much everything covered now. I'm now awaiting the new evaluation evaluation status.

svanderburg · 2021-02-03T21:27:09Z

@SuperSandro2000 @turboMaCk I think we're ready right? I intend to merge this very soon, or feel free to click on the merge button 👍

turboMaCk · 2021-02-04T07:13:16Z

Agree - 👍 merge

collares · 2021-02-18T13:09:38Z

@timokau @omasanori I forgot to disable the intermittent segfaulting Sage test, which masked the fact that a three.js upgrade here broke another Sage test. Apologies for not taking action earlier, I will fix the three.js breakage and disable the other test today.

timokau · 2021-02-26T14:05:31Z

Thanks @collares. For reference: #113603

svanderburg marked this pull request as draft January 25, 2021 19:38

svanderburg mentioned this pull request Jan 25, 2021

Revert "nodePackages: regenerate with node2nix 1.9.0" #110752

Merged

ofborg bot added the 8.has: clean-up label Jan 25, 2021

ofborg bot requested review from midchildan, turboMaCk, freezeboy, michojel and iblech January 25, 2021 19:48

ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels Jan 25, 2021

SuperSandro2000 reviewed Jan 25, 2021

View reviewed changes

pkgs/applications/networking/cluster/spacegun/default.nix Show resolved Hide resolved

turboMaCk mentioned this pull request Jan 26, 2021

elmPackages: Updates Elm node packages to latest versions. #110845

Closed

10 tasks

yurrriq mentioned this pull request Jan 27, 2021

aws-azure-login: init at 3.3.0 #110634

Merged

10 tasks

svanderburg force-pushed the node2nix-update branch from 40fc29c to 8ba7dfa Compare February 2, 2021 16:06

svanderburg marked this pull request as ready for review February 2, 2021 16:30

svanderburg changed the title ~~[WIP]: nodePackages: regenerate with node2nix 1.9.0~~ nodePackages: regenerate with node2nix 1.9.0 Feb 2, 2021

svanderburg force-pushed the node2nix-update branch from 8ba7dfa to e752616 Compare February 2, 2021 19:14

svanderburg force-pushed the node2nix-update branch from e752616 to cb52887 Compare February 2, 2021 20:46

svanderburg reopened this Feb 2, 2021

svanderburg requested review from Ericson2314 and matthewbauer as code owners February 2, 2021 20:52

svanderburg force-pushed the node2nix-update branch from be2a98a to 9c6cafc Compare February 2, 2021 20:53

ofborg bot added the 6.topic: stdenv Standard environment label Feb 2, 2021

turboMaCk approved these changes Feb 2, 2021

View reviewed changes

SuperSandro2000 approved these changes Feb 3, 2021

View reviewed changes

regenerate with node2nix 1.9.0 except zigbee2mqtt

84a0978

svanderburg force-pushed the node2nix-update branch from 9c6cafc to 84a0978 Compare February 3, 2021 18:53

ofborg bot removed the 6.topic: stdenv Standard environment label Feb 3, 2021

svanderburg merged commit b32335b into NixOS:master Feb 4, 2021

oxalica mentioned this pull request Feb 4, 2021

vscode-extensions.vadimcn.vscode-lldb: 1.5.3 -> 1.6.1 and refactor #101179

Merged

10 tasks

turboMaCk mentioned this pull request Feb 6, 2021

elmPackages: updates with node2nix 1.9.0 #112160

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nodePackages: regenerate with node2nix 1.9.0 #110813

nodePackages: regenerate with node2nix 1.9.0 #110813

svanderburg commented Jan 25, 2021

svanderburg commented Jan 25, 2021

iblech commented Jan 25, 2021

SuperSandro2000 commented Jan 25, 2021 •

edited

svanderburg commented Jan 26, 2021 •

edited

SuperSandro2000 commented Jan 27, 2021

svanderburg commented Jan 27, 2021

turboMaCk commented Jan 27, 2021

SuperSandro2000 commented Jan 27, 2021

svanderburg commented Jan 28, 2021

svanderburg commented Feb 2, 2021 •

edited

raboof commented Feb 2, 2021

turboMaCk commented Feb 2, 2021 •

edited

svanderburg commented Feb 2, 2021

svanderburg commented Feb 2, 2021

svanderburg commented Feb 2, 2021

turboMaCk commented Feb 2, 2021 •

edited

svanderburg commented Feb 2, 2021 •

edited

turboMaCk left a comment

svanderburg commented Feb 2, 2021

turboMaCk commented Feb 2, 2021

SuperSandro2000 commented Feb 3, 2021

svanderburg commented Feb 3, 2021

SuperSandro2000 commented Feb 3, 2021

SuperSandro2000 commented Feb 3, 2021

SuperSandro2000 Feb 3, 2021

svanderburg commented Feb 3, 2021

svanderburg commented Feb 3, 2021

svanderburg commented Feb 3, 2021

turboMaCk commented Feb 4, 2021

collares commented Feb 18, 2021

timokau commented Feb 26, 2021

nodePackages: regenerate with node2nix 1.9.0 #110813

nodePackages: regenerate with node2nix 1.9.0 #110813

Conversation

svanderburg commented Jan 25, 2021

Motivation for this change

Things done

svanderburg commented Jan 25, 2021

iblech commented Jan 25, 2021

SuperSandro2000 commented Jan 25, 2021 • edited

svanderburg commented Jan 26, 2021 • edited

SuperSandro2000 commented Jan 27, 2021

svanderburg commented Jan 27, 2021

turboMaCk commented Jan 27, 2021

SuperSandro2000 commented Jan 27, 2021

svanderburg commented Jan 28, 2021

svanderburg commented Feb 2, 2021 • edited

raboof commented Feb 2, 2021

turboMaCk commented Feb 2, 2021 • edited

svanderburg commented Feb 2, 2021

svanderburg commented Feb 2, 2021

svanderburg commented Feb 2, 2021

turboMaCk commented Feb 2, 2021 • edited

svanderburg commented Feb 2, 2021 • edited

turboMaCk left a comment

Choose a reason for hiding this comment

svanderburg commented Feb 2, 2021

turboMaCk commented Feb 2, 2021

SuperSandro2000 commented Feb 3, 2021

svanderburg commented Feb 3, 2021

SuperSandro2000 commented Feb 3, 2021

SuperSandro2000 commented Feb 3, 2021

SuperSandro2000 Feb 3, 2021

Choose a reason for hiding this comment

svanderburg commented Feb 3, 2021

svanderburg commented Feb 3, 2021

svanderburg commented Feb 3, 2021

turboMaCk commented Feb 4, 2021

collares commented Feb 18, 2021

timokau commented Feb 26, 2021

SuperSandro2000 commented Jan 25, 2021 •

edited

svanderburg commented Jan 26, 2021 •

edited

svanderburg commented Feb 2, 2021 •

edited

turboMaCk commented Feb 2, 2021 •

edited

turboMaCk commented Feb 2, 2021 •

edited

svanderburg commented Feb 2, 2021 •

edited