Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poly2tri-c: move away from untrusted repo to one that is owned by its Nixpkgs maintainer #110764

Merged
merged 1 commit into from Jan 25, 2021
Merged

poly2tri-c: move away from untrusted repo to one that is owned by its Nixpkgs maintainer #110764

merged 1 commit into from Jan 25, 2021

Conversation

erictapen
Copy link
Member

Motivation for this change

poly2tri-c hasn't been under development for a long time. Using unrelated Google code exports on Github is suboptimal but not easy to avoid. But as @jtojnar, the maintainer of the package also owns a fork on gitlab.gnome.org, I'd vouch to use this as source.

See also:
https://gitlab.gnome.org/GNOME/gegl/-/issues/214#note_1002908
#109812

Things done

I tested that the src hash still matches and doesn't need to be altered.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@erictapen erictapen added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 25, 2021
@jtojnar jtojnar merged commit db4cede into NixOS:master Jan 25, 2021
@jtojnar
Copy link
Contributor

jtojnar commented Jan 25, 2021

Thanks.

@erictapen
Copy link
Member Author

Backport in 91ec582.

@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erictapen @jtojnar