Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware-horizon-client: 2006 -> 2012 #110780

Merged
merged 1 commit into from Jan 31, 2021
Merged

vmware-horizon-client: 2006 -> 2012 #110780

merged 1 commit into from Jan 31, 2021

Conversation

buckley310
Copy link
Contributor

Motivation for this change

Keep the vmware client up-to-date.

Reformat package source with nixpkgs-fmt

Fixed bugs (#109312):

  • Would not run under minimal window managers. Fixed by explicitly adding gsettings schemas.
  • Could not log in using oauth when chromium was set as a default browser. Fixed by removing third party libjpeg.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Jan 25, 2021
View reviewed changes
pkgs/applications/networking/remote/vmware-horizon-client/default.nix
@@ -37,7 +37,7 @@
, zlib
}:
let
version = "2006";
version = "2012";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the version different from the one in the URL? Maybe this should be unified and an update script added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL has both 8.1.0 and 2012. All their releases have two version numbers now. The 2006/2012 versioning is newer, so it seems like they are switching away from the 8.x and toward the [YYMM] format. Also when you go to download it the version dropdown has the 2012 version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how the update script will work since at least part of the URL is always random, Maybe some website scraping can do it, but haven't looked into it yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converted to a Draft while I look into an update script. It seems less impossible than I previously thought.

SuperSandro2000
SuperSandro2000 requested changes Jan 25, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please squash the commits.

pkgs/applications/networking/remote/vmware-horizon-client/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/remote/vmware-horizon-client/default.nix Outdated Show resolved Hide resolved
@buckley310 buckley310 force-pushed the vmwareview branch 2 times, most recently from 6d56685 to 14b8df7 Compare January 25, 2021 19:30
@buckley310 buckley310 marked this pull request as draft January 25, 2021 20:49
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110780 run on x86_64-linux 1

1 package built:
  • vmware-horizon-client

@buckley310
vmware-horizon-client: 2006 -> 2012
a25b47a 
vmware-horizon-client: add missing gsettings schemas

vmware-horizon-client: change whitespace, and "lib" argument

vmware-horizon-client: fix library issues with chromium

vmware-horizon-client: add updater script
@buckley310 buckley310 marked this pull request as ready for review January 26, 2021 15:23
@buckley310 buckley310 force-pushed the vmwareview branch 2 times, most recently from 2ae19ec to a25b47a Compare January 30, 2021 07:51
@SuperSandro2000 SuperSandro2000 merged commit a17a03e into NixOS:master Jan 31, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110780 run on x86_64-linux 1

1 package built:
  • vmware-horizon-client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@buckley310 @SuperSandro2000