Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] cryptopp: 8.2.0 -> 8.4.0 #110795

Merged
merged 2 commits into from Jan 27, 2021
Merged

[20.09] cryptopp: 8.2.0 -> 8.4.0 #110795

merged 2 commits into from Jan 27, 2021

Conversation

LeSuisse
Copy link
Contributor

Motivation for this change

Fixes CVE-2019-14318.

Cherry picked from commit eefdd09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from c0bw3b January 25, 2021 17:10
@dotlambda
Copy link
Member

python27Packages.pycryptopp and scylladb fail for me

@LeSuisse
Copy link
Contributor Author

The scylladb package was broken before this patch. Should we also backport 88033a4?

For python27Packages.pycryptopp I'm not sure what the right play is. The pycryptopp seems to be more or less abandoned (no Python 3 compat, no development activity upstream) so it might needs some work to be compatible.

Backporting only the security fix to limit the chances of breaking the pycryptopp package might also not that easy. A partial patch is available at weidai11/cryptopp#869 (comment) it seems that to have the full fix (and the fix for the regression introduced by the fix) we need at least:

@dotlambda
Copy link
Member

I suggest we just set doCheck = false.

dotlambda
dotlambda requested changes Jan 26, 2021
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should start with pythonPackages.pycryptopp.

@LeSuisse
pythonPackages.pycryptopp: do not run tests
818f083 
The tests do not work with the latest version of Crypto++.
@LeSuisse
cryptopp: 8.2.0 -> 8.4.0
490b3f2 
Fixes CVE-2019-14318.

(cherry picked from commit eefdd09)
@erictapen
Copy link
Member

This is the backport of #110555

@dotlambda
Copy link
Member

@ofborg build python3.pkgs.beaker python2.pkgs.pycryptopp

@dotlambda dotlambda merged commit f327293 into NixOS:release-20.09 Jan 27, 2021
@erictapen
Copy link
Member

I was just looking into the test failure of pycryptopp. Am somewhat hesitant to just turn off tests on interpreted languages, but I couldn't find an easy solution either.

Also this broke cryfs, and therefore libsForQt5.plasmavault.

@erictapen
Copy link
Member

Reading the release notes, it looks like 8.4.0 actually reintroduces CVE-2019-14318.

Only 8.3.0 does have the fix, but it seems to make things worse.

So I guess it'd make sense to revert this PR? It doesn't have a security benefit and it breaks packages.

See also my comment on the original PR.

erictapen added a commit to erictapen/nixpkgs that referenced this pull request Jan 27, 2021
@erictapen
Revert "pythonPackages.pycryptopp: do not run tests"
0b682c3 
This reverts commit 818f083.

See NixOS#110795 (comment).
erictapen added a commit to erictapen/nixpkgs that referenced this pull request Jan 27, 2021
@erictapen
Revert "cryptopp: 8.2.0 -> 8.4.0"
e2768fd 
This reverts commit 490b3f2.

See NixOS#110795 (comment).
@erictapen erictapen mentioned this pull request Jan 27, 2021
Merged
10 tasks
erictapen added a commit that referenced this pull request Jan 27, 2021
@erictapen
Revert "pythonPackages.pycryptopp: do not run tests"
859e0ba 
This reverts commit 818f083.

See #110795 (comment).
erictapen added a commit that referenced this pull request Jan 27, 2021
@erictapen
Revert "cryptopp: 8.2.0 -> 8.4.0"
6e20bc6 
This reverts commit 490b3f2.

See #110795 (comment).
@LeSuisse LeSuisse deleted the cryptopp-8.4.0-20.09 branch January 27, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@c0bw3b c0bw3b Awaiting requested review from c0bw3b

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
1.severity: security 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LeSuisse @dotlambda @erictapen