Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

byrd: init at git-20200312 #110831

Closed
wants to merge 1 commit into from
Closed

byrd: init at git-20200312 #110831

wants to merge 1 commit into from

Conversation

anna328p
Copy link
Member

Motivation for this change

byrd is a simple terminal emulator.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zakame
Copy link
Member

zakame commented Jan 26, 2021

Result of nixpkgs-review pr 110831 run on Other x86_64-linux 1

1 package built:
  • byrd

That said, the resulting binary is mostly useless without the corresponding Byrd.conf also shipped (as perhaps an example.)

@anna328p
Copy link
Member Author

Revised.

SuperSandro2000
SuperSandro2000 requested changes Jan 27, 2021
View reviewed changes
pkgs/applications/terminal-emulators/byrd/default.nix
install -m 0755 -t $out/bin byrd
'';

meta = with stdenv.lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with stdenv.lib; {
meta = with lib; {

pkgs/applications/terminal-emulators/byrd/default.nix
@@ -0,0 +1,31 @@
{ stdenv, fetchFromGitHub, vte, libconfig, glib, pkg-config }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ stdenv, fetchFromGitHub, vte, libconfig, glib, pkg-config }:
{ lib, stdenv, fetchFromGitHub, vte, libconfig, glib, pkg-config }:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new. I've always used stdenv.lib; when was this change introduced?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it is new. The change was 18 days ago c06b2b3#diff-b0739f44f25865ddf604159bdc99cc82f3c192f46b92215da2594d3e5747f0b0.

stdenv.lib is eventually removed and doing changes which introduce new occurrences of it are not allowed anymore.

@stale
Copy link

stale bot commented Jul 27, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 27, 2021
@anna328p
Copy link
Member Author

this was a sample PR to demonstrate the process of adding something to nixpkgs for someone. i do not think this is worth merging

@anna328p anna328p closed this Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anna328p @zakame @SuperSandro2000