Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

legendary-gl: 0.20.1 -> 0.20.6 #110823

Merged
merged 3 commits into from Jan 31, 2021
Merged

legendary-gl: 0.20.1 -> 0.20.6 #110823

merged 3 commits into from Jan 31, 2021

Conversation

equirosa
Copy link
Contributor

Motivation for this change

New versions released with some improvements:
https://github.com/derrod/legendary/releases/tag/0.20.6

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from wchresta January 26, 2021 00:06
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110823 run on x86_64-darwin 1

1 package built:
  • legendary-gl

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

legendary-gl:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110823 run on x86_64-linux 1

1 package built:
  • legendary-gl

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

legendary-gl:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

@equirosa @SuperSandro2000
fix pythonImportsCheck
d816ef7 
change parameter from "requests" to "legendary"

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110823 run on x86_64-darwin 1

1 package built:
  • legendary-gl

wchresta
wchresta suggested changes Jan 30, 2021
View reviewed changes
pkgs/games/legendary-gl/default.nix Show resolved Hide resolved
pkgs/games/legendary-gl/default.nix Outdated Show resolved Hide resolved
@equirosa
Copy link
Contributor Author

equirosa commented Jan 31, 2021 via email

@SuperSandro2000
Copy link
Member

Very well! I'll change it in a bit. 😊

Please leave the tests disabled.

@ofborg ofborg bot requested a review from wchresta January 31, 2021 18:46
@SuperSandro2000 SuperSandro2000 merged commit 66bf902 into NixOS:master Jan 31, 2021
@wchresta
Copy link
Member

wchresta commented Jan 31, 2021 •
edited

Thank you, @equirosa :)

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 31, 2021 •
edited

I don't understand this @SuperSandro2000 . Obviously you have put a lot of thought into this, so there must be something I'm missing

I copied this from jonringer and added an automated way to check the build logs for it.

The next version has tests

The maintainer should check the release notes and if there are new tests adjust the package to execute them.

pythonImportsCheck checks for missing packages which catches most of the bugs. If the package is more complicated and requires patching than the maintainer should test it properly anyway.

For example if we switch from PyPi to GitHub sources we do not want tests to be executed if they wheren't run before and have potentially failing tests.

And the default way we execute tests with setuptools is phasing out anyway and most test suites require pytest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@wchresta wchresta wchresta requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@equirosa @SuperSandro2000 @wchresta