libxkbcommon: Enable libxkbregistry #110773
Merged
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also enables the "list" subcommand of xkbcli. Since libxkbregistry is an optional library we could install it into a different output. However, doing this properly is quite challenging and the best approach would likely be to upstream patches that add a Meson option for installing libxkbregistry under a separate prefix (so that the pkg-config file is generated correctly, etc.). But even then the default fixup phase would try to move $libxkbregistry/include into the $dev output and the $out output would depend on the $libxkbcommon output because of the xkbcli binary (though we could move that into a $bin output). As a result it seems best not to install libxkbregistry into a dedicated output path.
10 tasks
|
This is a followup on #108004. We could e.g. do one of the following things:
Some data regarding other Linux distributions:
|
ofborg
bot
added
11.by: package-maintainer
|
Debian packages it as libxkbcommon-doc, libxkbregistry-dev and libxkbregistry0. But please remember that Debian creates a package for almost anything. |
|
@primeos Do you know how much it adds in terms of closure size?
Debian benefits from the fact that it uses FHS so, for them, splitting a package is just moving files around. For us, it requires mucking around with the project’s build system. I want to make it easier for Meson projects to create subprojects that can be installed separately but did not get to it yet. |
Right, I forgot to check and provide that information :o Console output: $ # Before / without this PR:
$ for output in out dev doc; do nix path-info --size $(nix-build -A libxkbcommon.$output) && nix path-info --closure-size $(nix-build -A libxkbcommon.$output); done | column -t
/nix/store/ks6j3z7ycp9y246dw09pbhgrsci45a5j-libxkbcommon-1.0.3 449536
/nix/store/ks6j3z7ycp9y246dw09pbhgrsci45a5j-libxkbcommon-1.0.3 43429712
/nix/store/ckirmdja00wb209aqqlgwz9f3j0i1m11-libxkbcommon-1.0.3-dev 314272
/nix/store/ckirmdja00wb209aqqlgwz9f3j0i1m11-libxkbcommon-1.0.3-dev 43743984
/nix/store/h8gkpsx3bkl57j9mclmmiqvyh852lkfk-libxkbcommon-1.0.3-doc 1026736
/nix/store/h8gkpsx3bkl57j9mclmmiqvyh852lkfk-libxkbcommon-1.0.3-doc 1026736
$ # After / with this PR:
$ for output in out dev doc; do nix path-info --size $(nix-build -A libxkbcommon.$output) && nix path-info --closure-size $(nix-build -A libxkbcommon.$output); done | column -t
/nix/store/0ahpqm5ll42bbrkiw052gll8wv67mswh-libxkbcommon-1.0.3 512160
/nix/store/0ahpqm5ll42bbrkiw052gll8wv67mswh-libxkbcommon-1.0.3 45346264
/nix/store/fc0xcnyhj2amk47hjq7zaqgz6ngvpgiz-libxkbcommon-1.0.3-dev 339136
/nix/store/fc0xcnyhj2amk47hjq7zaqgz6ngvpgiz-libxkbcommon-1.0.3-dev 45685400
/nix/store/cq7ws1w9sc1ygi4zr0zlg23mc5admrw1-libxkbcommon-1.0.3-doc 1026736
/nix/store/cq7ws1w9sc1ygi4zr0zlg23mc5admrw1-libxkbcommon-1.0.3-doc 1026736I forgot to mention that the libxml2 dependency which I added in the previous PR is only needed for The main contributor to the $ nix path-info -S /nix/store/4cny85dmpnfcfvmf7s50q90gn8pngna2-libxml2-2.9.10
/nix/store/4cny85dmpnfcfvmf7s50q90gn8pngna2-libxml2-2.9.10 34791952
$ nix path-info -S /nix/store/gafigwfaimlziam6qhw1m8dz4h952g1n-glibc-2.32-35
/nix/store/gafigwfaimlziam6qhw1m8dz4h952g1n-glibc-2.32-35 32938024So I assume it should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also enables the "list" subcommand of xkbcli.
Since libxkbregistry is an optional library we could install it into a
different output. However, doing this properly is quite challenging and
the best approach would likely be to upstream patches that add a Meson
option for installing libxkbregistry under a separate prefix (so that
the pkg-config file is generated correctly, etc.).
But even then the default fixup phase would try to move
$libxkbregistry/include into the $dev output and the $out output would
depend on the $libxkbcommon output because of the xkbcli binary (though
we could move that into a $bin output).
As a result it seems best not to install libxkbregistry into a dedicated
output path.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)