Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pygdbmi: 0.9.0.2 -> 0.10.0.0, gdbgui: 0.13.2.1 -> 0.14.0.2 #110785

Merged
merged 2 commits into from Jan 25, 2021
Merged

python3Packages.pygdbmi: 0.9.0.2 -> 0.10.0.0, gdbgui: 0.13.2.1 -> 0.14.0.2 #110785

merged 2 commits into from Jan 25, 2021

Conversation

jollheef
Copy link
Member

Motivation for this change

Bump pygdbmi to the latest version, and gdbgui which is depends on it.

Note: gdbgui was broken on the unstable branch, so there is also a fix of dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Mic92 and yrashk January 25, 2021 15:54
@SuperSandro2000 SuperSandro2000 changed the title Bump pygdbmi, gdbgui python3Packages.pygdbmi: 0.9.0.2 -> 0.10.0.0, gdbgui: 0.13.2.1 -> 0.14.0.2 Jan 25, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110785 run on x86_64-darwin 1

4 packages built:
  • gdbgui
  • python37Packages.pygdbmi
  • python38Packages.pygdbmi
  • python39Packages.pygdbmi

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110785 run on x86_64-linux 1

4 packages built:
  • gdbgui
  • python37Packages.pygdbmi
  • python38Packages.pygdbmi
  • python39Packages.pygdbmi

@balsoft
Copy link
Member

balsoft commented Jan 25, 2021

Tested with:

nix shell github:jollheef/nixpkgs/pygdbmi-0.10.0.0#gdbgui -c gdbgui

Everything seems to work fine.

@SuperSandro2000 SuperSandro2000 merged commit 5452d8d into NixOS:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@Mic92 Mic92 Awaiting requested review from Mic92

@yrashk yrashk Awaiting requested review from yrashk

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jollheef @SuperSandro2000 @balsoft