Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxPackages.rtl8192eu: 4.4.1.20200620 -> unstable-2021-01-11 #110786

Closed
wants to merge 2 commits into from

Conversation

patrykf03
Copy link

@patrykf03 patrykf03 commented Jan 25, 2021

Motivation for this change

fixed the build on recent kernels

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 110786 run on x86_64-linux 1

1 package failed to build:
  • linuxPackages-libre.rtl8192eu
16 packages built:
  • linuxPackages.rtl8192eu
  • linuxPackages_4_14.rtl8192eu
  • linuxPackages_4_19.rtl8192eu
  • linuxPackages_4_4.rtl8192eu
  • linuxPackages_4_9.rtl8192eu
  • linuxPackages_5_10.rtl8192eu
  • linuxPackages_hardened.rtl8192eu
  • linuxPackages_latest-libre.rtl8192eu
  • linuxPackages_latest_hardened.rtl8192eu
  • linuxPackages_latest_xen_dom0.rtl8192eu
  • linuxPackages_latest_xen_dom0_hardened.rtl8192eu
  • linuxPackages_lqx.rtl8192eu
  • linuxPackages_testing_bcachefs.rtl8192eu
  • linuxPackages_xen_dom0.rtl8192eu
  • linuxPackages_xen_dom0_hardened.rtl8192eu
  • linuxPackages_zen.rtl8192eu

Error for linuxPackages-libre.rtl8192eu:

builder for '/nix/store/hg7kjfjgffx9p5wcpc2yg19g31x6va1l-linux-config-5.4.92.drv' failed with exit code 1; last 10 log lines:
  applying patch /nix/store/mnlqwys9dxznjcvq4w3s0435s9ql8qv8-bridge-stp-helper.patch
  patching file net/bridge/br_private.h
  Hunk #1 succeeded at 46 (offset 7 lines).
  applying patch /nix/store/mbz5gln1q4swlzmqs2399br98qjif9kn-request-key-helper.patch
  patching file security/keys/request_key.c
  applying patch /nix/store/2lr5rrl7ipi8yf0vw8bacqxv1xaw7gph-rtl8761b-support.patch
  patching file drivers/bluetooth/btrtl.c
  Hunk #1 FAILED at 130.
  Hunk #2 succeeded at 255 (offset 4 lines).
  1 out of 2 hunks FAILED -- saving rejects to file drivers/bluetooth/btrtl.c.rej
cannot build derivation '/nix/store/rvnjsf94c4lccjjyivq9133xvp61l7vj-linux-5.4.92.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ssv533mzgzdlh1r28jdn8vhy3hnra5ih-rtl8192eu-5.4.92-unstable-2021-01-11.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/6jhfl1x1prwvdka6hp9jyx1ib72a04aq-env.drv': 1 dependencies couldn't be built

I don't think that is related to this PR, so LGTM :)

@troydm
Copy link
Contributor

troydm commented Jan 26, 2021

@patrykf03 why did you changed the version to ' version = "unstable-2021-01-11"; ' ?
Correct version would be version = "4.4.1.20210111", please don't break version lineage for this package, besides the point that this driver is pretty much stable :)

Copy link
Contributor

@troydm troydm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version needs to be consistent with previous format

@ofborg ofborg bot requested a review from troydm January 28, 2021 00:34
@stale
Copy link

stale bot commented Jul 27, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 27, 2021
@troydm
Copy link
Contributor

troydm commented Jul 30, 2021

@patrykf03 could you please resolve merge conflict for your changes

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 30, 2021
@stale
Copy link

stale bot commented Apr 19, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 19, 2022
@SuperSamus
Copy link
Contributor

I guess this can be closed with #177642 being merged.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 9, 2022
@troydm
Copy link
Contributor

troydm commented Aug 10, 2022

Yup, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants