Codechange: Implement a constructor for CurrencySpec (fixes VS2017 compile failure) #8607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
VS2017 fails to compile our current code with
While the error is weird (and probably incorrect as VS2019 has no issue with our code), I think implicit copy from
const char[]
(string literal) tochar[]
is not fully legit.Description
I added a constructor to do the copy without implicit casting.
Of course that removed the default constructor, so I re-added it.
And with that VS2017 succeeds to build
Limitations
None I can think of.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.