Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qemu: desktop files not built for emulation #110800

Closed
wants to merge 1 commit into from
Closed

qemu: desktop files not built for emulation #110800

wants to merge 1 commit into from

Conversation

baloo
Copy link
Member

@baloo baloo commented Jan 25, 2021

Motivation for this change

Qemu will only install desktop files on "system" builds,
if you build qemu for emulation (eg: aarch64-linux-user) as
it is used for nix emulated builds, build will fail with error:
rm: cannot remove '/nix/store/nzwv6nkzidyp6vvclip70a5kw1vlvwpp-qemu-5.2.0/share/applications/qemu.desktop': No such file or directory

As it is not installed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@baloo baloo changed the title qemu: desktop files not build for emulation qemu: desktop files not built for emulation Jan 25, 2021
@baloo
qemu: desktop files not built for emulation
910f569 
Qemu will only install desktop files on "system" builds,
if you build qemu for emulation (eg: aarch64-linux-user) as
it is used for nix emulated builds, build will fail with error:
  rm: cannot remove '/nix/store/nzwv6nkzidyp6vvclip70a5kw1vlvwpp-qemu-5.2.0/share/applications/qemu.desktop': No such file or directory

As it is not installed.

Signed-off-by: Arthur Gautier <baloo@superbaloo.net>
@baloo baloo force-pushed the baloo/qemu-emulated-systems branch from eb0651e to 910f569 Compare January 25, 2021 18:00
@lovesegfault
Copy link
Member

Duplicate of #110721

@lovesegfault lovesegfault marked this as a duplicate of #110721 Jan 25, 2021
@ofborg ofborg bot requested a review from edolstra January 25, 2021 18:10
@baloo baloo closed this Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@baloo @lovesegfault