/marvin opt-in
/status needs_reviewer

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

Result of nixpkgs-review pr 110825 run on x86_64-linux 1

Quartus and Houdini failed to build because they're proprietary applications with non-public links to download their application and/or dependency, generating an error like this:

builder for '/nix/store/dvjhy3jw3ada0qmngl824nrf864k649q-QuartusLiteSetup-20.1.0.711-linux.run.drv' failed with exit code 1; last 10 log
lines:
  ***
  Unfortunately, we cannot download file QuartusLiteSetup-20.1.0.711-linux.run automatically.
  Please go to https://fpgasoftware.intel.com/20.1/?edition=lite&platform=linux to download it yourself, and add it to the Nix store
  using either
    nix-store --add-fixed sha256 QuartusLiteSetup-20.1.0.711-linux.run
  or
    nix-prefetch-url --type sha256 file:///path/to/QuartusLiteSetup-20.1.0.711-linux.run

  ***

builder for '/nix/store/yn339vhzjihjx9gy1dfcm8qc2g0h2j61-houdini-17.5.327-linux_x86_64_gcc6.3.tar.gz.drv' failed with exit code 1; last 1
0 log lines:
  Download it from https://www.sidefx.com and add it to the nix store with:

      nix-prefetch-url <URL>

  This can't be done automatically because you need to create an account on
  their website and agree to their license terms before you can download
  it. That's what you get for using proprietary software.

  ***

So it seems fine.

Links in rambox-pro still doesn't work for me, but this may be related to #108995 since I use release-20.09.

My only issue with this PR is that it affects everything that uses buildFHSUserEnv, so the implications are probably bigger than I have as context.

Maybe @Atemu or @abbradar can help reviewing here 🤔 ?

I am only using two appimage apps: rambox and ledger-live-desktop. I had issues on both which are fixed by this PR. I think besides appimages the other big user of FHS is Steam, which I don't use and therefore haven't tested. Probably makes sense to test manually before merging this PR.

Links in rambox-pro still doesn't work for me, but this may be related to #108995 since I use release-20.09.

Maybe you have some other issue related to XDG then. For me the issue was that my browser was not on the FHS's path since it is symlinked in /etc/profiles/per-user/{username}.

Happy to report that I have installed Steam and played some games, everything seemed to be working fine.

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be should be put back in the needs_reviewer queue in one day.

Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually.