Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oraclejdk8: 8u271 -> 8u281 #110798

Merged
merged 2 commits into from Jan 29, 2021
Merged

oraclejdk8: 8u271 -> 8u281 #110798

merged 2 commits into from Jan 29, 2021

Conversation

bbjubjub2494
Copy link
Member

@bbjubjub2494 bbjubjub2494 commented Jan 25, 2021 •
edited

Motivation for this change

Patch release, update recommended by upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bbjubjub2494
Copy link
Member Author

Result of nixpkgs-review pr 110798 run on x86_64-linux 1

1 package failed to build:
  • processing
8 packages built:
  • docear
  • ib-controller
  • ib-tws
  • javacard-devkit
  • jrePlugin (jre8Plugin)
  • oraclejdk (oraclejdk8)
  • oraclejre (oraclejre8)
  • sqldeveloper

Result of nixpkgs-review pr 110798 run on aarch64-linux 1

1 package marked as broken and skipped:
  • processing
6 packages built:
  • docear
  • ib-controller
  • ib-tws
  • jrePlugin (jre8Plugin)
  • oraclejdk (oraclejdk8)
  • oraclejre (oraclejre8)

@bbjubjub2494 bbjubjub2494 marked this pull request as ready for review January 25, 2021 18:37
@bbjubjub2494
Copy link
Member Author

bbjubjub2494 commented Jan 25, 2021 •
edited

processing breaks w/ the updated jdk.

@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/5jggjh0cb1q4yzycxqzpk0r8b3nyfijb-source
source root is source
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
no configure script, doing nothing
@nix { "action": "setPhase", "phase": "buildPhase" }
building
Buildfile: /build/source/build/build.xml

build:

ignore-tools:
     [echo] Ignore the 'Unable to locate tools.jar' message.
     [echo] The tools.jar file is not required to build Processing.

check-linux-arm32:

check-linux-arm64:

revision-check:

linux-check-os:

subprojects-build:

methods-check:

methods-build:

compile:
    [mkdir] Created dir: /build/source/core/methods/bin
    [javac] Compiling 1 source file to /build/source/core/methods/bin

dist:
      [jar] Building jar: /build/source/core/methods/methods.jar

compile:
  [methods] No changes to PApplet API.
    [mkdir] Created dir: /build/source/core/bin
    [javac] Compiling 56 source files to /build/source/core/bin
    [javac] ----------
    [javac] 1. ERROR in /build/source/core/src/processing/javafx/PSurfaceFX.java (at line 249)
    [javac] 	float renderScale = Screen.getMainScreen().getRenderScale();
    [javac] 	                                           ^^^^^^^^^^^^^^
    [javac] The method getRenderScale() is undefined for the type Screen
    [javac] ----------
    [javac] 2. ERROR in /build/source/core/src/processing/javafx/PSurfaceFX.java (at line 252)
    [javac] 	renderScale = Math.max(renderScale, s.getRenderScale());
    [javac] 	                                      ^^^^^^^^^^^^^^
    [javac] The method getRenderScale() is undefined for the type Screen
    [javac] ----------
    [javac] 3. ERROR in /build/source/core/src/processing/javafx/PSurfaceFX.java (at line 255)
    [javac] 	float uiScale = Screen.getMainScreen().getUIScale();
    [javac] 	                                       ^^^^^^^^^^
    [javac] The method getUIScale() is undefined for the type Screen
    [javac] ----------
    [javac] 3 problems (3 errors)

BUILD FAILED
/build/source/build/build.xml:290: The following error occurred while executing this line:
/build/source/build/build.xml:346: The following error occurred while executing this line:
/build/source/core/build.xml:57: Compile failed; see the compiler error output for details.

@bbjubjub2494 bbjubjub2494 mentioned this pull request Jan 27, 2021
Closed
@bbjubjub2494
Copy link
Member Author

Processing is patched. The patch has been submitted upstream, they haven't opined on it yet.

@Ma27 Ma27 merged commit 526738a into NixOS:master Jan 29, 2021
@bbjubjub2494 bbjubjub2494 deleted the update/oraclejdk8 branch January 29, 2021 23:09
@bbjubjub2494
Copy link
Member Author

Processing is patched. The patch has been submitted upstream, they haven't opined on it yet.

For the record, upstream won't merge. We already differed from them in that we kept JDK8 up-to-date whereas they didn't.

Processing 3.5.4 uses the JDK 8u202 because of licensing changes by Oracle after that release that prevent us from distributing the software.

processing/processing#6156 (comment)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/java-webstart-nixos-18-09/1136/11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbjubjub2494 @nixos-discourse @Ma27