Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/systems: fix linuxArch for power + riscv #110828

Merged
merged 1 commit into from Jan 26, 2021
Merged

lib/systems: fix linuxArch for power + riscv #110828

merged 1 commit into from Jan 26, 2021

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Jan 26, 2021 •
edited

Looks like these got left behind in the
kernelArch -> linuxArch migration.

cc @Ericson2314

Fixes:

  • pkgsCross.powernv.linuxHeaders
  • pkgsCross.riscv64.linuxHeaders
  • pkgsCross.riscv32.linuxHeaders

and dependees

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-burns
lib/systems: fix linuxArch for power + riscv
8baac2a 
Looks like these got left behind in the
kernelArch -> linuxArch migration.

Fixes:
* pkgsCross.powernv.linuxHeaders
* pkgsCross.riscv64.linuxHeaders
* pkgsCross.riscv32.linuxHeaders
and dependees
@Ericson2314 Ericson2314 merged commit 054f792 into NixOS:master Jan 26, 2021
@Ericson2314
Copy link
Member

Thanks @r-burns; I owe you one for all the follow-up issues you've caught!

@r-burns r-burns deleted the ppc64-riscv-linux-arch branch January 26, 2021 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r-burns @Ericson2314