Skip to content

yuzu-mainline: 482 -> 517 && yuzu-ea: init at 1377 #110810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2021
Merged

yuzu-mainline: 482 -> 517 && yuzu-ea: init at 1377 #110810

merged 2 commits into from
Feb 1, 2021
+106 −47

Conversation

IvarWithoutBones
Copy link
Member

@IvarWithoutBones IvarWithoutBones commented Jan 25, 2021 •
edited
Loading

Motivation for this change

This updates the yuzu-mainline package, and adds the early-access branch. I've made adding different branches simpler in the process.

This supersedes #99656 as this builds from source and is on the latest version as of writing this.

@aanderse you might find this interesting :)

@SuperSandro2000 @jonringer you both reviewed the previous pineapple PR, so i thought you might be interested in reviewing this one as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@IvarWithoutBones
yuzu: 482 -> 517 && rename to yuzu-mainline

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: ED58F95069B004F5
Learn about vigilant mode
d66c499
@IvarWithoutBones IvarWithoutBones mentioned this pull request Jan 25, 2021
Closed
10 tasks
@IvarWithoutBones
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 25, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2 needs_reviewer (old Marvin label, do not use) labels Jan 25, 2021
SuperSandro2000
SuperSandro2000 reviewed Jan 25, 2021
View reviewed changes
@marvin-mk2 marvin-mk2 bot added awaiting_reviewer (old Marvin label, do not use) and removed needs_reviewer (old Marvin label, do not use) labels Jan 25, 2021
@IvarWithoutBones
Copy link
Member Author

IvarWithoutBones commented Jan 27, 2021 •
edited
Loading

@SuperSandro2000 Applied all your suggestions 👍

Should be ready to merge now :)

@aanderse
Copy link
Member

@IvarWithoutBones will build now and test likely tomorrow. Thanks for the ping ☺️

@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels Jan 27, 2021
@ofborg ofborg bot requested a review from JoshuaFern January 27, 2021 01:25
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 27, 2021
@aanderse
Copy link
Member

yuzu-mainline ended up building faster than I thought. So far so good, everything runs perfect. Thanks again!

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110810 run on x86_64-linux 1

2 packages built:
  • yuzu-ea
  • yuzu-mainline

JoshuaFern
JoshuaFern approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@JoshuaFern JoshuaFern left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Edit: Not super important but can we get working version numbers instead of GIT-NOTFOUND GIT-NOTFOUND?

@marvin-mk2
Copy link

marvin-mk2 bot commented Feb 1, 2021

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be should be put back in the needs_reviewer queue in one day.

Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually.

@aanderse
Copy link
Member

aanderse commented Feb 1, 2021

@SuperSandro2000 have your comments been adequately addressed? Are you happy to merge?

@SuperSandro2000
Copy link
Member

Not super important but can we get working version numbers instead of GIT-NOTFOUND GIT-NOTFOUND?

I was waiting for an answer on this but not that important as stated.

@SuperSandro2000 SuperSandro2000 merged commit 1c51dd2 into NixOS:master Feb 1, 2021
@aanderse
Copy link
Member

aanderse commented Feb 1, 2021

Thanks @SuperSandro2000!

@IvarWithoutBones IvarWithoutBones mentioned this pull request Feb 23, 2021
Merged
10 tasks
@IvarWithoutBones IvarWithoutBones deleted the yuzu-{mainline,ea} branch January 3, 2022 20:25
@IvarWithoutBones IvarWithoutBones mentioned this pull request Jan 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000

@JoshuaFern JoshuaFern

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes awaiting_reviewer (old Marvin label, do not use) marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@IvarWithoutBones @aanderse @SuperSandro2000 @JoshuaFern