Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ijq: init at 0.2.3 #110809

Merged
merged 1 commit into from Feb 1, 2021
Merged

ijq: init at 0.2.3 #110809

merged 1 commit into from Feb 1, 2021

Conversation

justinas
Copy link
Contributor

Motivation for this change

ijq provides an interactive TUI for writing jq expressions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member

fabaff commented Jan 25, 2021

Result of nixpkgs-review pr 110809 run on x86_64-linux 1

1 package built:
  • ijq

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110809 run on x86_64-darwin 1

1 package built:
  • ijq

@tomberek
Copy link
Contributor

Result of nixpkgs-review pr 110809 run on x86_64-linux 1

1 package built:
  • ijq

@@ -5166,6 +5166,8 @@ in
packages = config.ihaskell.packages or (self: []);
};

ijq = callPackage ../development/tools/ijq { } ;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ijq = callPackage ../development/tools/ijq { } ;
ijq = callPackage ../development/tools/ijq { };

meta = with lib; {
description = "Interactive wrapper for jq";
homepage = "https://git.sr.ht/~gpanders/ijq";
license = licenses.gpl3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpl3Only or gpl3Plus?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the file header it's gpl3Plus.

@justinas
Copy link
Contributor Author

justinas commented Feb 1, 2021

Fixed according to the comments and squashed.

@SuperSandro2000 SuperSandro2000 merged commit ccda8c6 into NixOS:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants