Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL2: 2.0.12 -> 2.0.14 #110200

Closed
wants to merge 1 commit into from
Closed

SDL2: 2.0.12 -> 2.0.14 #110200

wants to merge 1 commit into from

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Jan 20, 2021

Motivation for this change

http://hg.libsdl.org/SDL/raw-file/e52d96ea04fc/WhatsNew.txt

Things done

Recreated a patch. Tested with chocolate-doom.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ehmry ehmry requested a review from cpages January 20, 2021 18:41
@SuperSandro2000
Copy link
Member

I think we should think about targeting staging with this.

@ehmry ehmry changed the base branch from master to staging January 20, 2021 19:15
@cpages
Copy link
Contributor

cpages commented Jan 20, 2021

@ehmry you probably already noticed it by now, but I already pushed 2.0.14 to staging :/ Feel free to push your extra stdenv removal change, and adding yourself as reviewer, though. Your help is more than welcome, since sometimes I react a bit late to updates

@ehmry
Copy link
Contributor Author

ehmry commented Jan 20, 2021

Nah, I'll just close this, should have checked staging.

@ehmry ehmry closed this Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpages cpages Awaiting requested review from cpages

Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ehmry @SuperSandro2000 @cpages