Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scalameta.metals: 1.9.7->1.9.10 #107340

Merged
merged 1 commit into from Jan 20, 2021
Merged

scalameta.metals: 1.9.7->1.9.10 #107340

merged 1 commit into from Jan 20, 2021

Conversation

scalavision
Copy link
Contributor

@scalavision scalavision commented Dec 21, 2020 •
edited

Motivation for this change

aligning scalameta.metals with last version of Scala 3.0.0-M3. This version of scala has full support for Scala.js and other improvements, so it would be very nice to have this in.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [x ] Ensured that relevant documentation is up to date
  • [x ] Fits CONTRIBUTING.md.

@scalavision scalavision force-pushed the update-scalameta.metals-to-1.9.10 branch from 51c30c6 to 70ea8a1 Compare December 21, 2020 19:30
@scalavision scalavision changed the title scalameta.metals: 1.9.9->1.9.10 scalameta.metals: 1.9.7->1.9.10 Dec 21, 2020
prusnak
prusnak approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested, change looks OK

@fabianhjr fabianhjr mentioned this pull request Dec 21, 2020
Merged
@scalavision
Copy link
Contributor Author

Yeah.. I have problems building things locally with some error on the python plugin. I haven't found a nice way to only build this plugin, without all the other dependencies ..

@scalavision
Copy link
Contributor Author

scalavision commented Dec 22, 2020 •
edited

seems this did the trick:

nix-build -E 'with import <nixpkgs> {}; callPackage ./default.nix { }' -A scalameta.metals

then symlinking in manually. Tested the plugin now, it works as expected.

@SuperSandro2000
Copy link
Member

@scalavision please fix the eval error.

@scalavision
Copy link
Contributor Author

what do you mean @SuperSandro2000 , is it the problem with ofborg? How can I fix it?

@SuperSandro2000
Copy link
Member

is it the problem with ofborg? How can I fix it?

yes. It is required to be green before the PR can be merged.

@ofborg eval

@scalavision
Copy link
Contributor Author

oki, hm... didn't know I had privilege to do that :-) Thanks for helping out!

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107340 run on x86_64-linux 1

1 package built:
  • vscode-extensions.scalameta.metals

@SuperSandro2000 SuperSandro2000 merged commit 96df69a into NixOS:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scalavision @SuperSandro2000 @prusnak