Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform-providers.shell: provider source address #110160

Merged
merged 1 commit into from Jan 20, 2021
Merged

terraform-providers.shell: provider source address #110160

merged 1 commit into from Jan 20, 2021

Conversation

mupdt
Copy link
Contributor

@mupdt mupdt commented Jan 20, 2021

Motivation for this change

Terraform 0.13 (and later) have changed the filesystem location of providers.

This change makes sure that the terraform-provider-shell provider is now copied to the location where Terraform 0.13+ will be able to find it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc: @marsam @zimbatm

@mupdt mupdt requested review from marsam and zimbatm January 20, 2021 13:26
@mupdt mupdt changed the title [21.05] terraform-providers.shell: provider source address terraform-providers.shell: provider source address Jan 20, 2021
@mupdt mupdt force-pushed the terraform-provider-shell-source-address branch from 484efad to bf750e4 Compare January 20, 2021 14:29
@zimbatm zimbatm merged commit 6a1bee3 into NixOS:master Jan 20, 2021
anandsuresh pushed a commit to anandsuresh/nixpkgs that referenced this pull request Jan 28, 2021
@mupdt @anandsuresh
terraform-providers.shell: provider source address (NixOS#110160)
e961066 
(cherry picked from commit 6a1bee3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam Awaiting requested review from marsam

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mupdt @zimbatm