Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ldaptor: run tests #110151

Merged
merged 2 commits into from Jan 20, 2021
Merged

pythonPackages.ldaptor: run tests #110151

merged 2 commits into from Jan 20, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @lheckemann This completely disables privacyidea-ldap-proxy since that project does not support Python 3 while ldaptor does not support Python 2.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110151 run on x86_64-linux 1

2 packages built:
  • python37Packages.ldaptor
  • python38Packages.ldaptor

@SuperSandro2000 SuperSandro2000 merged commit 0e21aef into NixOS:master Jan 20, 2021
@dotlambda dotlambda deleted the ldaptor-tests branch January 20, 2021 14:10
@lheckemann
Copy link
Member

This breaks the ldap-proxy part of the privacyidea module, so I'm going to (partially) revert it and run the tests only on py3k.

@dotlambda
Copy link
Member Author

This breaks the ldap-proxy part of the privacyidea module, so I'm going to (partially) revert it and run the tests only on py3k.

But ldaptor does not support Python 2: https://github.com/twisted/ldaptor/blob/v20.1.1/setup.cfg#L22

@lheckemann
Copy link
Member

Ah yes, I misunderstood. Ugh, I guess the ldap-proxy project is dead.

@dotlambda
Copy link
Member Author

You could package an old version of ldaptor for Python 2.

@lheckemann
Copy link
Member

We're going to need to migrate away from ldap-proxy to an alternative or pick up maintenance for it, since running EOL python isn't a long-term solution either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lheckemann lheckemann Awaiting requested review from lheckemann

@maxxk maxxk Awaiting requested review from maxxk

@globin globin Awaiting requested review from globin

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @SuperSandro2000 @lheckemann