Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphicsmagick: 1.3.35 -> 1.3.36 #110207

Merged
merged 1 commit into from Jan 30, 2021
Merged

graphicsmagick: 1.3.35 -> 1.3.36 #110207

merged 1 commit into from Jan 30, 2021

Conversation

LeSuisse
Copy link
Contributor

@LeSuisse LeSuisse commented Jan 20, 2021 •
edited by dotlambda

Motivation for this change

Fix for CVE-2020-12672 (#88318).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

fixes #88318

@SuperSandro2000 SuperSandro2000 added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 20, 2021
taku0
taku0 approved these changes Jan 30, 2021
View reviewed changes
Copy link
Contributor

@taku0 taku0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine on Linux and macOS.

@dotlambda dotlambda merged commit 35f48cf into NixOS:master Jan 30, 2021
@dotlambda
Copy link
Member

@LeSuisse Will you do the backport?

@LeSuisse LeSuisse deleted the graphicsmagick-1.3.36 branch February 1, 2021 07:49
@LeSuisse LeSuisse added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taku0 taku0 taku0 approved these changes

@TredwellGit TredwellGit TredwellGit approved these changes

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 84: graphicsmagick-1.3.35: 1 advisory
5 participants
@LeSuisse @dotlambda @taku0 @TredwellGit @SuperSandro2000