Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.mirage-crypto*: 0.8.8 -> 0.8.10 #110235

Merged
merged 1 commit into from Jan 21, 2021
Merged

ocamlPackages.mirage-crypto*: 0.8.8 -> 0.8.10 #110235

merged 1 commit into from Jan 21, 2021

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Jan 20, 2021 •
edited

Motivation for this change

Bugfix releases:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member Author

Waiting on: mirleft/ocaml-x509#143

@sternenseemann sternenseemann marked this pull request as draft January 20, 2021 23:19
@sternenseemann sternenseemann changed the title ocamlPackages.mirage-crypto*: 0.8.8 -> 0.8.9 ocamlPackages.mirage-crypto*: 0.8.8 -> 0.8.10 Jan 21, 2021
@sternenseemann
ocamlPackages.mirage-crypto*: 0.8.8 -> 0.8.10
f195e3d 
ocamlPackages.x509: fix tests for mirage-crypto >= 0.8.9
@sternenseemann sternenseemann marked this pull request as ready for review January 21, 2021 18:41
@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build ocamlPackages.x509

@vbgl
Copy link
Contributor

vbgl commented Jan 21, 2021

@GrahamcOfBorg build dune-release jackline

@vbgl vbgl merged commit 80b1336 into NixOS:master Jan 21, 2021
@sternenseemann sternenseemann deleted the mirage-crypto-0.8.9 branch January 21, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl Awaiting requested review from vbgl

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sternenseemann @vbgl