Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.glicko: unbreak #110161

Merged
merged 1 commit into from Jan 22, 2021
Merged

haskellPackages.glicko: unbreak #110161

merged 1 commit into from Jan 22, 2021

Conversation

Prillan
Copy link
Contributor

@Prillan Prillan commented Jan 20, 2021

I'm the author of the package and fixed the dependencies upstream, now builds correctly and can be unmarked as broken.

Tested with current unstable (4eccd6f).

nix-shell -p 'haskellPackages.ghcWithPackages (pkgs: [pkgs.glicko])' -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/4eccd6f731627ba5ad9915bcf600c9329a34ca78.tar.gz

@iblech
Copy link
Contributor

iblech commented Jan 20, 2021

Can confirm that glicko builds just fine, thank you for your work :-)

cdepillabout
cdepillabout requested changes Jan 21, 2021
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prillan Can you rebase this on the haskell-updates branch (and make sure to change the base branch here on GitHub as well)?

After you make this change, I'll merge in this PR.

We generally try to make most Haskell-related changes to the haskell-updates branch. That branch gets merged into master about once a week. Here's the next PR that will get merged into master, in case you want to follow progress: #109474

@Prillan
haskellPackages.glicko: unbreak
ce994c1 
I'm the author of the package and fixed the dependencies upstream,
now builds correctly and can be unmarked as broken.
@Prillan Prillan changed the base branch from master to haskell-updates January 21, 2021 12:21
@Prillan
Copy link
Contributor Author

Prillan commented Jan 21, 2021

@Prillan Can you rebase this on the haskell-updates branch (and make sure to change the base branch here on GitHub as well)?

After you make this change, I'll merge in this PR.

Done!

We generally try to make most Haskell-related changes to the haskell-updates branch. That branch gets merged into master about once a week. Here's the next PR that will get merged into master, in case you want to follow progress: #109474

Alright, that makes sense, thanks!

@cdepillabout
Copy link
Member

@Prillan Thanks for unbreaking this.

@iblech and thanks for reviewing.

@cdepillabout cdepillabout merged this pull request into NixOS:haskell-updates Jan 22, 2021
@Prillan Prillan deleted the unbreak-glicko branch January 22, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Prillan @iblech @cdepillabout @Janik-Haag