Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mednaffe: small fixup #110165

Merged
merged 1 commit into from Jan 20, 2021
Merged

mednaffe: small fixup #110165

merged 1 commit into from Jan 20, 2021

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Jan 20, 2021 •
edited

A fixup to the ubiquitous problem of "GTK variables not found". Now the app
doesn't segfault when opening a window.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AndersonTorres
mednaffe: small fixup
54a4477 
A fixup to the ubiquitous problem of "GTK variables not found". Now the app
doesn't segfault when opening a window.
@ofborg ofborg bot requested a review from lukateras January 20, 2021 13:53
@iblech
Copy link
Contributor

iblech commented Jan 20, 2021

Thank you for the fix :-) I just tested it here and confirm that it works. (However, I should confess that it also worked before. :-) Do you know why?)

I noticed that mednaffe complains about a missing icon: Could not find the icon 'list-remove-symbolic-ltr'. The 'hicolor' theme was not found either, perhaps you need to install it. Should we add hicolor-icon-theme to the buildInputs? (I'm not familiar with gtk packaging.)

@AndersonTorres
Copy link
Member Author

I am way less familiar with GTK idiosyncrasies...

@AndersonTorres AndersonTorres merged commit 610f0eb into NixOS:master Jan 20, 2021
@AndersonTorres AndersonTorres deleted the mednafen branch January 20, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras Awaiting requested review from lukateras

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndersonTorres @iblech