Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collection 4: substituteInPlace cleanups, pythonPackages.azure-synapse-artifacts: Fix meta #110210

Merged
merged 7 commits into from Jan 20, 2021

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

Comment on lines +26 to +27
description = "Microsoft Azure Synapse Artifacts Client Library for Python";
homepage = "https://github.com/Azure/azure-sdk-for-python";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops... thanks

@SuperSandro2000
Copy link
Member Author

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110210 run on x86_64-darwin 1

6 packages marked as broken and skipped:
  • python37Packages.bellows
  • python37Packages.optuna
  • python38Packages.bellows
  • python38Packages.optuna
  • python39Packages.bellows
  • python39Packages.google-music
23 packages built:
  • appdaemon
  • gdbgui
  • google-music-scripts
  • python37Packages.audio-metadata
  • python37Packages.bidict
  • python37Packages.flask-socketio
  • python37Packages.google-music
  • python37Packages.google-music-proto
  • python37Packages.google-music-utils
  • python37Packages.python-socketio
  • python38Packages.audio-metadata
  • python38Packages.bidict
  • python38Packages.flask-socketio
  • python38Packages.google-music
  • python38Packages.google-music-proto
  • python38Packages.google-music-utils
  • python38Packages.python-socketio
  • python39Packages.audio-metadata
  • python39Packages.bidict
  • python39Packages.flask-socketio
  • python39Packages.google-music-proto
  • python39Packages.google-music-utils
  • python39Packages.python-socketio

@SuperSandro2000
Copy link
Member Author

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110210 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • python37Packages.optuna
  • python38Packages.optuna
30 packages built:
  • appdaemon
  • gdbgui
  • google-music-scripts
  • python37Packages.audio-metadata
  • python37Packages.bellows
  • python37Packages.bidict
  • python37Packages.flask-socketio
  • python37Packages.google-music
  • python37Packages.google-music-proto
  • python37Packages.google-music-utils
  • python37Packages.mxnet
  • python37Packages.python-socketio
  • python37Packages.spyder
  • python38Packages.audio-metadata
  • python38Packages.bellows
  • python38Packages.bidict
  • python38Packages.flask-socketio
  • python38Packages.google-music
  • python38Packages.google-music-proto
  • python38Packages.google-music-utils
  • python38Packages.mxnet
  • python38Packages.python-socketio
  • spyder (python38Packages.spyder)
  • python39Packages.audio-metadata
  • python39Packages.bellows
  • python39Packages.bidict
  • python39Packages.flask-socketio
  • python39Packages.google-music-proto
  • python39Packages.mxnet
  • python39Packages.python-socketio

@SuperSandro2000 SuperSandro2000 merged commit c4965b4 into NixOS:master Jan 20, 2021
@SuperSandro2000 SuperSandro2000 deleted the fix-collection4 branch January 20, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants