Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/chromium: Add ungoogled-chromium and Google Chrome #110198

Merged
merged 2 commits into from Jan 20, 2021
Merged

nixos/tests/chromium: Add ungoogled-chromium and Google Chrome #110198

merged 2 commits into from Jan 20, 2021

Conversation

primeos
Copy link
Member

@primeos primeos commented Jan 20, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
nixos/tests/chromium: Add ungoogled-chromium and Google Chrome
ff8866e 
By default only `chromium` will be tested but other "channels" can be
selected using e.g.:
nix-build nixos/tests/chromium.nix -A ungoogled

This also adds me as secondary maintainer (I'd like to get notified on
PRs/issues and can review them).
@primeos
chromium/doc: Explain how to run the VM tests
70206c3
@SuperSandro2000
Copy link
Member

@ofborg test chromium

@primeos
Copy link
Member Author

primeos commented Jan 20, 2021

The CI test for tests.chromium should unfortunately timeout because the latest Chromium update is not yet built/cached by Hydra but I just needed the other checks to pass anyway (mainly because I'm a bit concerned that the addition of Google Chrome might cause weird issues because of the unfree license but that case should be covered - and tbh ofborg usually doesn't catch these special-/edge-cases anyway :o).

@primeos primeos merged commit 88637a1 into NixOS:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@primeos @SuperSandro2000