ocamlPackages: irmin 2.2.0 → 2.4.0; git: 2.13 → 3.2.0; and related changes #110184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 46 packages built:
|
sternenseemann
force-pushed
the
irmin-2.3.0
branch
7 times, most recently
from
2a721e5
to
74b2484
Compare
|
Getting the following build error for
|
|
Merged the addition of |
sternenseemann
force-pushed
the
irmin-2.3.0
branch
from
74b2484
to
b55528f
Compare
|
@sternenseemann, don't know, unfortunately I don't know much of OCaml. |
|
Patching in a reference to repr in the dune file fixes this issue, but there are further incompatibilities with irmin 2.3.0 breaking the build. I'm uncertain what to do about this since we can't update I'm half-tempted to mark |
|
So be it, wodan-irmin isn't a dependency of anything yet. |
sternenseemann
force-pushed
the
irmin-2.3.0
branch
2 times, most recently
from
931e0e2
to
b190757
Compare
sternenseemann
changed the title
|
I've added the updates to irmin 2.4.0, carton 0.2.0 and git 2.3.0 in here as well. As separate commits because this may help reviewing, but I can also squash the updates together if you want. |
sternenseemann
force-pushed
the
irmin-2.3.0
branch
from
b190757
to
ee8bd42
Compare
vbgl
requested changes
Feb 12, 2021
sternenseemann
force-pushed
the
irmin-2.3.0
branch
from
ee8bd42
to
195fac0
Compare
It doesn't support those versions anymore, I've now adjusted |
vbgl
reviewed
Feb 14, 2021
sternenseemann
force-pushed
the
irmin-2.3.0
branch
from
195fac0
to
a2c26e1
Compare
|
Incorporated your suggestions, good finds! I've also squashed all updates of the same packages as rebasing got complicated. |
|
Result of 1 package marked as broken and skipped:
28 packages built:
|
Replaced by irmin.mem contained in ocamlPackages.irmin >= 2.4.0
ocamlPackages.git-unix: 2.1.3 -> 3.2.0
ocamlPackages.git-cohttp{,-unix,-mirage}: init at 3.2.0
sternenseemann
force-pushed
the
irmin-2.3.0
branch
from
a2c26e1
to
2d650b3
Compare
vbgl
reviewed
Feb 15, 2021
ocamlPackages.irmin-containers: init at 2.4.0 ocamlPackages.irmin-layers: init at 2.4.0 ocamlPackages.irmin-mirage: init at 2.4.0 ocamlPackages.irmin-mirage-git: init at 2.4.0 ocamlPackages.irmin-mirage-graphql: init at 2.4.0
sternenseemann
force-pushed
the
irmin-2.3.0
branch
from
2d650b3
to
2fd7655
Compare
vbgl
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This pull request updates
gitandirminto their latest versions and adds some missing packages for them (most notably their-mirage*variants, reference #23955).All other changes are related to this as these updates and new packaages are (indirectly) required by these updates. Some of them can be reviewed and merged separately and their commits are also PR'd separately:
ocamlPackages.hxd: init at 0.2.0 #109758ocamlPackages.bheap: init at 2.0.0 #109757ocamlPackages.{repr,ppx_repr}: init at 0.2.1 #109756ocamlPackages: init xenstore, xenstore_transport, vchan, tls-mirage, conduit-mirage and cohttp-mirage #109621ocamlPackages: pecu: init at 0.5; emile: init at 1.1 #109439Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)