Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdu: 3.0.0 -> 4.2.0 #110227

Merged
merged 1 commit into from Jan 21, 2021
Merged

gdu: 3.0.0 -> 4.2.0 #110227

merged 1 commit into from Jan 21, 2021

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jan 20, 2021

https://github.com/dundee/gdu/releases/tag/v4.0.0
https://github.com/dundee/gdu/releases/tag/v4.1.0
https://github.com/dundee/gdu/releases/tag/v4.2.0

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110227 run on x86_64-darwin 1

1 package built:
  • gdu

@fabaff
Copy link
Member

fabaff commented Jan 21, 2021

Result of nixpkgs-review pr 110227 run on x86_64-linux 1

1 package built:
  • gdu

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...ew/pr-110227-1]$ ./results/gdu/bin/gdu -h
Pretty fast disk usage analyzer written in Go.

Gdu is intended primarily for SSD disks where it can fully utilize parallel processing.
However HDDs work as well, but the performance gain is not so huge.
[...]

...ew/pr-110227-1]$ ./results/gdu/bin/gdu -v
Version:	 4.2.0
Built time:	 
Built user:	 

..ew/pr-110227-1]$ man results/gdu/share/man/man1/gdu.1.gz 
gdu(1)                                                                                                                                                                                                                                                          gdu(1)

NAME
       gdu - Pretty fast disk usage analyzer written in Go

SYNOPSIS
       gdu [directory_to_scan] [flags]
[...]

Looks good to me.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110227 run on x86_64-linux 1

1 package built:
  • gdu

@SuperSandro2000 SuperSandro2000 merged commit ad7347c into NixOS:master Jan 21, 2021
@zowoq zowoq deleted the gdu branch January 21, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants