Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] sqlite: 3.34.0 -> 3.34.1 #110241

Merged
merged 1 commit into from Jan 23, 2021
Merged

[staging] sqlite: 3.34.0 -> 3.34.1 #110241

merged 1 commit into from Jan 23, 2021

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jan 20, 2021

https://www.sqlite.org/releaselog/3_34_1.html

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq zowoq changed the title sqlite: 3.34.0 -> 3.34.1 [staging] sqlite: 3.34.0 -> 3.34.1 Jan 21, 2021
@zowoq zowoq merged commit 049359d into NixOS:staging Jan 23, 2021
@zowoq zowoq deleted the sqlite branch January 23, 2021 01:38
bobrik
bobrik reviewed Feb 26, 2021
View reviewed changes
pkgs/development/libraries/sqlite/tools.nix
url = "https://sqlite.org/2020/sqlite-src-${archiveVersion version}.zip";
sha256 = "0giklai05shqalj1wwadi9hg5dx6vff8nrblqh9xxljnrq701hm5";
url = "https://sqlite.org/2021/sqlite-src-${archiveVersion version}.zip";
sha256 = "0giklai05shqalj1wwadi9hg5dx6vff8nrblqh9xxljnrq701h00";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something isn't right here:

hash mismatch in fixed-output derivation '/nix/store/xx4h0r6dd9wr842q2ccaz70p77xyjb29-sqlite-src-3340100.zip.drv':
  specified: sha256-AMAADs5W0t4TxHRli5zbprfyYIpNcR4kVRjqAqKiMz4=
     got:    sha256-3d0jeZawlt7os3FGx6N6YmqAMG1mlRA9LsFu47hS/0k=

See: https://hydra.nixos.org/job/nixpkgs/trunk/sqldiff.x86_64-linux

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 Thanks for catching this, looks like I didn't actually update the checksum.

Fixed in #114441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobrik bobrik bobrik left review comments

@JohnAZoidberg JohnAZoidberg Awaiting requested review from JohnAZoidberg

@np np Awaiting requested review from np

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @bobrik