Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aerc: replace an extra use of SHAREDIR #110181

Merged
merged 1 commit into from Feb 4, 2021
Merged

aerc: replace an extra use of SHAREDIR #110181

merged 1 commit into from Feb 4, 2021

Conversation

chvp
Copy link
Member

@chvp chvp commented Jan 20, 2021

Motivation for this change

Starting aerc without a config gives the following error:

Failed to load config: Unable to load default styleset: Can't find styleset "default" in any of [@SHAREDIR@/stylesets/]
Things done

Starting aerc with the modified patch runs without problems.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110181 run on x86_64-linux 1

1 package built:
  • aerc

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110181 run on x86_64-darwin 1

1 package built:
  • aerc

@chvp chvp force-pushed the pr/aerc-extra-path-replace branch 2 times, most recently from 65c9cb5 to eac7ccf Compare January 20, 2021 16:58
@chvp chvp changed the title aerc: replace an extra hardcoded path aerc: replace an extra use of SHAREDIR Jan 20, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110181 run on x86_64-linux 1

1 package built:
  • aerc

@chvp chvp force-pushed the pr/aerc-extra-path-replace branch from eac7ccf to d76bdf6 Compare January 21, 2021 09:43
@chvp
Copy link
Member Author

chvp commented Jan 21, 2021

@tadeokondrak I've added you as a reviewer since ofborg didn't do it.

tadeokondrak
tadeokondrak approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@tadeokondrak tadeokondrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, sorry about the late review

@Mic92 Mic92 merged commit b8edf8f into NixOS:master Feb 4, 2021
@chvp chvp deleted the pr/aerc-extra-path-replace branch February 5, 2021 08:43
This was referenced Feb 9, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadeokondrak tadeokondrak tadeokondrak approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chvp @SuperSandro2000 @tadeokondrak @Mic92