Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcsc-safenet: init at 10.0.37-0 #110193

Merged
merged 2 commits into from Jan 30, 2021
Merged

Conversation

wldhx
Copy link
Member

@wldhx wldhx commented Jan 20, 2021

Motivation for this change

A new take on #77786. Pcsc support for Aladdin / e5100 tokens, works for me with 0529:0620.

Closes #77786

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/tools/security/pcsc-safenet/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/pcsc-safenet/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/pcsc-safenet/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/pcsc-safenet/default.nix Show resolved Hide resolved
pkgs/tools/security/pcsc-safenet/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/pcsc-safenet/default.nix Show resolved Hide resolved
pkgs/tools/security/pcsc-safenet/default.nix Outdated Show resolved Hide resolved
@wldhx
Copy link
Member Author

wldhx commented Jan 20, 2021

@SuperSandro2000 This should be it, cheers!

Comment on lines 11 to 12
stdenv.mkDerivation rec {

pname = "pcsc-safenet";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stdenv.mkDerivation rec {
pname = "pcsc-safenet";
stdenv.mkDerivation rec {
pname = "pcsc-safenet";

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to add the package to all-packages.

@witchof0x20
Copy link
Contributor

Glad to see someone's picking this up. I forgot about this. I'll close mine once this is merged.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110193 run on x86_64-linux 1

1 package built:
  • pcsc-safenet

@SuperSandro2000 SuperSandro2000 merged commit 276a8ba into NixOS:master Jan 30, 2021
@Et7f3
Copy link
Contributor

Et7f3 commented Feb 10, 2023

Where did you get the binary from I don't see other version on this site. AUR seems to be using another repo again. Can you upgrade it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants