Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] cifs-utils: fix for CVE-2020-14342 #110215

Merged
merged 1 commit into from Feb 8, 2021
Merged

[20.09] cifs-utils: fix for CVE-2020-14342 #110215

merged 1 commit into from Feb 8, 2021

Conversation

LeSuisse
Copy link
Contributor

Motivation for this change

Did not backport 033208f because of some behavior changes in the CLIs.

The patch comes from the issue in the Samba bugtracker.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Jan 31, 2021

Could we not use fetchpatch to get this from https://bugzilla.samba.org/attachment.cgi?id=16149 ? We generally try to avoid keeping patches in-tree these days.

@risicle
Copy link
Contributor

risicle commented Jan 31, 2021

Full rebuild and nixosTests.samba happy for me though.

@LeSuisse LeSuisse force-pushed the 20.09-cifs-utils-CVE-2020-14342 branch from afa4388 to 619ca00 Compare February 1, 2021 08:06
@LeSuisse
cifs-utils: fix for CVE-2020-14342
88fd0ec 
Did not backport 033208f because of
some behavior changes in the CLIs.

The patch comes from the issue in the Samba bugtracker [0].

[0] https://bugzilla.samba.org/show_bug.cgi?id=14442
@LeSuisse LeSuisse force-pushed the 20.09-cifs-utils-CVE-2020-14342 branch from 619ca00 to 88fd0ec Compare February 8, 2021 07:58
@mweinelt mweinelt merged commit d217198 into NixOS:release-20.09 Feb 8, 2021
@LeSuisse LeSuisse deleted the 20.09-cifs-utils-CVE-2020-14342 branch February 8, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt left review comments

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LeSuisse @risicle @mweinelt