Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

twemoji-color-font: use prebuilt ttf, 12.0.1 -> 13.0.1 #110186

Merged
2 commits merged into from Feb 11, 2021
Merged

twemoji-color-font: use prebuilt ttf, 12.0.1 -> 13.0.1 #110186

2 commits merged into from Feb 11, 2021

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jan 20, 2021 •
edited

Motivation for this change

Closes #97871

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fgaz
twemoji-color-font: use prebuilt from release
9b44cb6 
Building from sources takes 1.5 hours on hydra for minimal advantages.
Relevant discussion:
NixOS#97871
@fgaz
twemoji-color-font: 12.0.1 -> 13.0.1
d8a884a
@fgaz fgaz changed the title Twemoji color font/dont build from source twemoji-color-font: use prebuilt ttf, 12.0.1 -> 13.0.1 Jan 20, 2021
@fgaz fgaz mentioned this pull request Jan 20, 2021
Closed
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110186 run on x86_64-linux 1

2 packages built:
  • ripcord
  • twemoji-color-font

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110186 run on x86_64-darwin 1

1 package built:
  • twemoji-color-font

@ghost ghost merged commit 50385ab into NixOS:master Feb 11, 2021
@fgaz fgaz deleted the twemoji-color-font/dont-build-from-source branch February 11, 2021 13:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

twemoji-color-font: Use release tarball font instead of building from source to reduce build times?
2 participants
@fgaz @SuperSandro2000